Skip to content
This repository was archived by the owner on Jun 10, 2018. It is now read-only.

Allow assets to be set lazily.#404

Closed
brandon-beacher wants to merge 1 commit intosstephenson:masterfrom
brandon-beacher:master
Closed

Allow assets to be set lazily.#404
brandon-beacher wants to merge 1 commit intosstephenson:masterfrom
brandon-beacher:master

Conversation

@brandon-beacher
Copy link
Copy Markdown

@josh
Copy link
Copy Markdown
Contributor

josh commented Jan 15, 2013

I don't think this is a good approach.

Encouraging this type of api would mean all the options should accept a lazy block, which is just a nasty direction. I regret supporting it for environment in the first. Probably consider that deprecated and possibly removed from Sprockets 2.0.

👎

@brandon-beacher
Copy link
Copy Markdown
Author

Agreed it feels icky. Callers are unlikely to ever use the block form.

Sounds like you've got a refactor on the back burner to simply delegate this through to the Rails app config?

Perhaps we go with this for now and then lazy environment and assets are refactored to delegates at the same time?

Or is that sliding too far down the slippery slope? ;)

@josh josh closed this Feb 7, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants