This repository was archived by the owner on Jun 10, 2018. It is now read-only.
Allow assets to be set lazily.#404
Closed
brandon-beacher wants to merge 1 commit intosstephenson:masterfrom
Closed
Allow assets to be set lazily.#404brandon-beacher wants to merge 1 commit intosstephenson:masterfrom
brandon-beacher wants to merge 1 commit intosstephenson:masterfrom
Conversation
This was referenced Jan 13, 2013
Contributor
|
I don't think this is a good approach. Encouraging this type of api would mean all the options should accept a lazy block, which is just a nasty direction. I regret supporting it for environment in the first. Probably consider that deprecated and possibly removed from Sprockets 2.0. 👎 |
Author
|
Agreed it feels icky. Callers are unlikely to ever use the block form. Sounds like you've got a refactor on the back burner to simply delegate this through to the Rails app config? Perhaps we go with this for now and then lazy Or is that sliding too far down the slippery slope? ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets the stage for rails/sprockets-rails#36
@josh @guilleiguaran