Revert "Start server process in dir where cmd was called"#629
Merged
jeremy merged 1 commit intorails:masterfrom Oct 23, 2020
deivid-rodriguez:revert_cwd_changes
Merged
Revert "Start server process in dir where cmd was called"#629jeremy merged 1 commit intorails:masterfrom deivid-rodriguez:revert_cwd_changes
jeremy merged 1 commit intorails:masterfrom
deivid-rodriguez:revert_cwd_changes
Conversation
This reverts commit 20d3a5f.
adrianna-chang-shopify
approved these changes
Oct 13, 2020
Contributor
adrianna-chang-shopify
left a comment
There was a problem hiding this comment.
Thank you! ❤️
Contributor
Author
|
Hello maintainers, thanks for finding time to maintain Is there any chance this PR could get a review? Since it broke existing tests and the original author agreed to revert, it seems quite straightforward :) I have several open PRs somewhat depending on each other, and I'd like to get things moving so we can improve the default experience when using |
Contributor
Author
|
Thanks so much @jeremy! 💜 |
entcheva
pushed a commit
to thoughtbot/factory_bot_rails
that referenced
this pull request
Jan 12, 2021
Changes introduced in spring 2.1.1 (rails/spring#621) are breaking some tests. That change was reverted in rails/spring#629, but hasn't been released yet. Until #629 is released, this PR skips Spring version 2.1.1. Co-authored-by: Daniel J. Colson <daniel.colson@hey.com>
entcheva
pushed a commit
to thoughtbot/factory_bot_rails
that referenced
this pull request
Jan 12, 2021
* Skip Spring version 2.1.1 Changes introduced in spring 2.1.1 (rails/spring#621) are breaking some tests. That change was reverted in rails/spring#629, but hasn't been released yet. Until #629 is released, this PR skips Spring version 2.1.1. * Bump to latest standard to match CI We are using the latest standard on CI. This bumps the version in the dev Gemfile to match, and fixes one violation. Co-authored-by: Daniel J. Colson <daniel.colson@hey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 20d3a5f.
As discussed with Adrianna, it was never expected that these changes broke existing specs, but we recently found out that they did. Until an alternative solution that doesn't break exisiting specs is found, we agreed on reverting the changes.