Seems good. But we have to fix the sass-rails related failures first.

Looks great so far 👍

Looking good, but looks like we'll need a way to convert existing assets.compress = true? There should be a smooth path from that setting, even if it's just a proper error message saying what to do.

On Oct 16, 2012, at 11:24 AM, Joshua Peek notifications@github.com wrote:

I've got railties passing under my sprockets-rails variant, not without some changes in behavior.

I've started outlining intentional changes in the README. Any other behavior changes are probably an oversight on my part.

I think the idea is I'd move my branch over to rails/sprocket-rails when this is approved.

/cc @dhh @jeremy @rafaelfranca @guilleiguaran

You can merge this Pull Request by running:

git pull https://github.com/josh/rails josh-sprockets-rails
Or view, comment on, or merge it at:

#7964

Commit Summary

• Switch to new sprockets-rails plugin
File Changes

• M Gemfile (2)
• M rails.gemspec (2)
• M railties/lib/rails/generators/app_base.rb (4)
• M railties/lib/rails/generators/rails/app/templates/config/environments/development.rb.tt (3)
• M railties/lib/rails/generators/rails/app/templates/config/environments/production.rb.tt (5)
• M railties/test/application/assets_test.rb (178)
• M railties/test/generators/app_generator_test.rb (3)
Patch Links

• https://github.com/rails/rails/pull/7964.patch
• https://github.com/rails/rails/pull/7964.diff
—
Reply to this email directly or view it on GitHub.

@guilleiguaran weren't you doing something about the compressor plugins so installing uglifer would make it available or something?

I'm not sure what to do about sass-rails, half that plugin should be deleted.

@josh confirmed. I removed almost all the sass-rails railties code and it is working. But I had to change the .css.scss files to .scss since the Sprockets::SassImporter doesn't recognize this extention.

@rafaelfranca sprockets doesn't add anything new to sass's importer. If theres some extra @import lookup feature, that will have to be added to sass core itself.

https://github.com/sstephenson/sprockets/blob/master/lib/sprockets/sass_importer.rb#L13-27

@josh there is an easy way to do this in the Sass::Importers::Filesystem. Can not we override this in Sprockets::SassImporter?

I'm 👍 to merge this one now. @guilleiguaran @dhh do you guys have any block?

@josh could you make our like easier and add the CHANGELOG entries?

Sent from my iPhone

On Oct 17, 2012, at 7:06 PM, Rafael Mendonça França notifications@github.com wrote:

I'm to merge this one now. @guilleiguaran @dhh do you guys have any block?

@josh could you make our like easier and add the CHANGELOG entries?

—
Reply to this email directly or view it on GitHub.

I'm going to switch over the rails/sprockets-rails plugin now.