Skip to content

Ensure PluginTestRunnerTest and TestRunnerInEngineTest use clean Bundler env#56247

Merged
yahonda merged 1 commit into
rails:mainfrom
zzak:re-56234
Nov 28, 2025
Merged

Ensure PluginTestRunnerTest and TestRunnerInEngineTest use clean Bundler env#56247
yahonda merged 1 commit into
rails:mainfrom
zzak:re-56234

Conversation

@zzak

@zzak zzak commented Nov 28, 2025

Copy link
Copy Markdown
Member

…ler env

Co-authored-by: Edouard CHIN <chin.edouard@gmail.com>
@yahonda

yahonda commented Nov 28, 2025

Copy link
Copy Markdown
Member

Confirmed #56247 addresses these errors.

  • main
$ cd railties/
$ ruby -v ; rm ../Gemfile.lock ; bundle install ; bundle exec ruby -Itest test/generators/plugin_test_runner_test.rb -n /test_run/ -v
ruby 4.0.0dev (2025-11-27T20:12:24Z :detached: 4cd6661e18) +PRISM [x86_64-linux]
Fetching gem metadata from https://rubygems.org/.........
Resolving dependencies...
Bundle complete! 81 Gemfile dependencies, 235 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.
1 installed gem you directly depend on is looking for funding.
  Run `bundle fund` for details
Run options: -n /test_run/ -v --seed 53406

# Running:

PluginTestRunnerTest#test_run_single_file = 2.68 s = .
PluginTestRunnerTest#test_run_multiple_files = /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/bundler/resolver.rb:356:in 'Bundler::Resolver#raise_not_found!': Could not find gems matching 'thruster' valid for all resolution platforms (aarch64-linux-android, arm-linux-androideabi, riscv64-linux-android, riscv64-linux-gnu, riscv64-linux-musl, x86_64-linux, x86_64-linux-android) in locally installed gems. (Bundler::GemNotFound)

The source contains the following gems matching 'thruster':
  * thruster-0.1.10-x86_64-linux
  * thruster-0.1.16-x86_64-linux
	from /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/bundler/resolver.rb:450:in 'block in Bundler::Resolver#prepare_dependencies'
	from /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/bundler/resolver.rb:425:in 'Hash#each'
	from /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/bundler/resolver.rb:425:in 'Enumerable#filter_map'
	from /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/bundler/resolver.rb:425:in 'Bundler::Resolver#prepare_dependencies'
	from /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/bundler/resolver.rb:63:in 'Bundler::Resolver#setup_solver'
	from /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/bundler/resolver.rb:28:in 'Bundler::Resolver#start'
	from /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/bundler/definition.rb:753:in 'Bundler::Definition#start_resolution'
	from /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/bundler/definition.rb:350:in 'Bundler::Definition#resolve'
	from /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/bundler/definition.rb:666:in 'Bundler::Definition#materialize'
	from /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/bundler/definition.rb:240:in 'Bundler::Definition#specs'
	from /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/bundler/definition.rb:312:in 'Bundler::Definition#specs_for'
	from /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/bundler/runtime.rb:18:in 'Bundler::Runtime#setup'
	from /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/bundler.rb:165:in 'Bundler.setup'
	from /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/bundler/setup.rb:32:in 'block in <top (required)>'
	from /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/bundler/ui/shell.rb:177:in 'Bundler::UI::Shell#with_level'
	from /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/bundler/ui/shell.rb:122:in 'Bundler::UI::Shell#silence'
	from /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/bundler/setup.rb:32:in '<top (required)>'
	from /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/rubygems.rb:1454:in 'Kernel#require'
	from /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/rubygems.rb:1454:in '<top (required)>'
	from <internal:gem_prelude>:2:in '<internal:gem_prelude>'
0.13 s = E


Error:
PluginTestRunnerTest#test_run_multiple_files:
RuntimeError: Command failed with exit 1: bundle
    test/plugin_helpers.rb:5:in 'Kernel#system'
    test/plugin_helpers.rb:5:in 'PluginHelpers#generate_plugin'
    test/generators/plugin_test_runner_test.rb:14:in 'PluginTestRunnerTest#setup'


bin/rails test test/generators/plugin_test_runner_test.rb:32

PluginTestRunnerTest#test_run_default = /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/bundler/resolver.rb:356:in 'Bundler::Resolver#raise_not_found!': Could not find gems matching 'thruster' valid for all resolution platforms (aarch64-linux-android, arm-linux-androideabi, riscv64-linux-android, riscv64-linux-gnu, riscv64-linux-musl, x86_64-linux, x86_64-linux-android) in locally installed gems. (Bundler::GemNotFound)

The source contains the following gems matching 'thruster':
  * thruster-0.1.10-x86_64-linux
  * thruster-0.1.16-x86_64-linux
	from /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/bundler/resolver.rb:450:in 'block in Bundler::Resolver#prepare_dependencies'
	from /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/bundler/resolver.rb:425:in 'Hash#each'
	from /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/bundler/resolver.rb:425:in 'Enumerable#filter_map'
	from /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/bundler/resolver.rb:425:in 'Bundler::Resolver#prepare_dependencies'
	from /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/bundler/resolver.rb:63:in 'Bundler::Resolver#setup_solver'
	from /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/bundler/resolver.rb:28:in 'Bundler::Resolver#start'
	from /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/bundler/definition.rb:753:in 'Bundler::Definition#start_resolution'
	from /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/bundler/definition.rb:350:in 'Bundler::Definition#resolve'
	from /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/bundler/definition.rb:666:in 'Bundler::Definition#materialize'
	from /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/bundler/definition.rb:240:in 'Bundler::Definition#specs'
	from /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/bundler/definition.rb:312:in 'Bundler::Definition#specs_for'
	from /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/bundler/runtime.rb:18:in 'Bundler::Runtime#setup'
	from /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/bundler.rb:165:in 'Bundler.setup'
	from /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/bundler/setup.rb:32:in 'block in <top (required)>'
	from /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/bundler/ui/shell.rb:177:in 'Bundler::UI::Shell#with_level'
	from /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/bundler/ui/shell.rb:122:in 'Bundler::UI::Shell#silence'
	from /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/bundler/setup.rb:32:in '<top (required)>'
	from /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/rubygems.rb:1454:in 'Kernel#require'
	from /home/yahonda/.local/share/mise/installs/ruby/trunk/lib/ruby/4.0.0+0/rubygems.rb:1454:in '<top (required)>'
	from <internal:gem_prelude>:2:in '<internal:gem_prelude>'
0.13 s = E


Error:
PluginTestRunnerTest#test_run_default:
RuntimeError: Command failed with exit 1: bundle
    test/plugin_helpers.rb:5:in 'Kernel#system'
    test/plugin_helpers.rb:5:in 'PluginHelpers#generate_plugin'
    test/generators/plugin_test_runner_test.rb:14:in 'PluginTestRunnerTest#setup'


bin/rails test test/generators/plugin_test_runner_test.rb:22


Finished in 2.935737s, 1.0219 runs/s, 0.6813 assertions/s.
3 runs, 2 assertions, 0 failures, 2 errors, 0 skips
$ git checkout -f
$ gh pr checkout 56247
$ ruby -v ; rm ../Gemfile.lock ; bundle install ; bundle exec ruby -Itest test/generators/plugin_test_runner_test.rb -n /test_run/ -v
ruby 4.0.0dev (2025-11-27T20:12:24Z :detached: 4cd6661e18) +PRISM [x86_64-linux]
Fetching gem metadata from https://rubygems.org/.........
Resolving dependencies...
Bundle complete! 81 Gemfile dependencies, 235 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.
1 installed gem you directly depend on is looking for funding.
  Run `bundle fund` for details
Run options: -n /test_run/ -v --seed 51193

# Running:

PluginTestRunnerTest#test_run_multiple_files = 2.65 s = .
PluginTestRunnerTest#test_run_single_file = 2.63 s = .
PluginTestRunnerTest#test_run_default = 2.61 s = .

Finished in 7.898989s, 0.3798 runs/s, 0.7596 assertions/s.
3 runs, 6 assertions, 0 failures, 0 errors, 0 skips
$

@yahonda yahonda merged commit 5322159 into rails:main Nov 28, 2025
4 checks passed
yahonda added a commit to yahonda/rails that referenced this pull request Nov 28, 2025
Ensure PluginTestRunnerTest and TestRunnerInEngineTest use clean Bundler env
yahonda added a commit to yahonda/rails that referenced this pull request Nov 28, 2025
Ensure PluginTestRunnerTest and TestRunnerInEngineTest use clean Bundler env
yahonda added a commit to yahonda/rails that referenced this pull request Nov 28, 2025
Ensure PluginTestRunnerTest and TestRunnerInEngineTest use clean Bundler env
@yahonda

yahonda commented Nov 28, 2025

Copy link
Copy Markdown
Member

Backported to supported Rails stable branches.

8-1-stable : 1e1ae85
8-0-stable : bf2b35e
7-2-stable : 77b8509

@zzak zzak deleted the re-56234 branch November 28, 2025 07:36
byroot pushed a commit that referenced this pull request Mar 17, 2026
Ensure PluginTestRunnerTest and TestRunnerInEngineTest use clean Bundler env
byroot pushed a commit that referenced this pull request Mar 17, 2026
Ensure PluginTestRunnerTest and TestRunnerInEngineTest use clean Bundler env
byroot pushed a commit that referenced this pull request Mar 17, 2026
Ensure PluginTestRunnerTest and TestRunnerInEngineTest use clean Bundler env
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PluginTestRunnerTest gets Could not find gems matching 'thruster' valid for all resolution platforms

2 participants