Fix .left_outer_joins when multiple associations have the same child.#52850
Merged
kamipo merged 1 commit intorails:mainfrom Sep 11, 2024
Merged
Fix .left_outer_joins when multiple associations have the same child.#52850kamipo merged 1 commit intorails:mainfrom
.left_outer_joins when multiple associations have the same child.#52850kamipo merged 1 commit intorails:mainfrom
Conversation
a3197bf to
2c961fd
Compare
Signed-off-by: Garrett Blehm <gblehm@fleetio.com>
2c961fd to
50bbff3
Compare
kamipo
added a commit
that referenced
this pull request
Sep 11, 2024
Remove unused require, quote support for sqlserver, etc.
kamipo
added a commit
that referenced
this pull request
Sep 12, 2024
Fix `.left_outer_joins` when multiple associations have the same child.
kamipo
added a commit
that referenced
this pull request
Sep 12, 2024
Fix `.left_outer_joins` when multiple associations have the same child.
dhh
added a commit
that referenced
this pull request
Sep 13, 2024
* main: Skip solid_cable gem if skip_action_cable is set (#52919) Call prerecord in test parallelization Fix a documentation name mismatch in cookies.rb Revert "Assign id attributes first in Active Record attribute assignment" Do not populate CurrentAttributes#attributes when not using defaults Suppress a RuboCop offense after running `rails new` with `--devcontainer` Fix small typo for Solid Cable changelog [ci skip] (#52911) Use less queries when updating nested attributes Load routes in LazyRoutesSet#recognize_path Slim down the gem section for Solid Add Solid Cable (#52889) Fix syntax error in user.rb Improve Active Record Association Callbacks docs [ci skip] Assign id attributes first in Active Record attribute assignment Always separate config blocks with a CR Fixup tests for #52850 Replace "healthcheck" with "health check" in documentation. [ci-skip]
DanielaVelasquez
pushed a commit
to DanielaVelasquez/rails
that referenced
this pull request
Oct 3, 2024
Remove unused require, quote support for sqlserver, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Fixes #41498
This Pull Request has been created to fix an issue where
.left_outer_joinsused with multiple associations that have the same child association but different parents does not join all parents.Detail
This Pull Request fixes #41498.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]