Use direct status code to avoid deprecation warnings.#52252
Closed
ioquatix wants to merge 3 commits into
Closed
Conversation
ff3dba3 to
18ff3f3
Compare
18ff3f3 to
d586b37
Compare
Contributor
|
Is |
Contributor
Author
|
Yes, IIUC, that's a reasonable usage. I think in the future (e.g. think once Rack 3.0 is dropped), we will probably want to remove this code. |
Contributor
Author
|
It looks like this is no longer needed as emitting a warning no longer causes test failures. |
Contributor
|
The warning was just suppressed here #52751, something should still happen. |
Contributor
Author
|
I agree. |
Contributor
|
Will you reopen or do you consider this done for now? I would recreate it if you have no interest in it anymore. |
Contributor
Author
|
I am happy to re-open it if there is a path towards getting it merged or rejected (both okay). |
Contributor
|
I'd say ask in the discord but I see you already did that🙃. Maybe bump in the discord and reopen? |
Earlopain
added a commit
to Earlopain/rails
that referenced
this pull request
Oct 19, 2024
Using `unprocessable_entity` will emit a warning on Rack 3.2. There have been various PRs in the past for this: * rails#52252 * rails#52192 * rails#52087 * rails#52097 This to me seems like the least invasive change and is also how headers are currently handled.
4 tasks
Earlopain
added a commit
to Earlopain/rails
that referenced
this pull request
Mar 3, 2025
Using `unprocessable_entity` will emit a warning on Rack 3.2. There have been various PRs in the past for this: * rails#52252 * rails#52192 * rails#52087 * rails#52097 This to me seems like the least invasive change and is also how headers are currently handled.
Earlopain
added a commit
to Earlopain/rails
that referenced
this pull request
Jul 23, 2025
Using `unprocessable_entity` will emit a warning on Rack 3.2. There have been various PRs in the past for this: * rails#52252 * rails#52192 * rails#52087 * rails#52097 This to me seems like the least invasive change and is also how headers are currently handled.
byroot
pushed a commit
to Earlopain/rails
that referenced
this pull request
Jul 31, 2025
Using `unprocessable_entity` will emit a warning on Rack 3.2. There have been various PRs in the past for this: * rails#52252 * rails#52192 * rails#52087 * rails#52097 This to me seems like the least invasive change and is also how headers are currently handled.
viralpraxis
pushed a commit
to viralpraxis/rails
that referenced
this pull request
Sep 22, 2025
Using `unprocessable_entity` will emit a warning on Rack 3.2. There have been various PRs in the past for this: * rails#52252 * rails#52192 * rails#52087 * rails#52097 This to me seems like the least invasive change and is also how headers are currently handled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
The HTTP status code 422 was informally referred to as "unprocessable entity" by the WebDAV specifications. However, it was officially standardised as "unprocessable content" by the HTTP standards. Rack adopted this change in v3.1 and emits deprecation warnings in v3.2 (HEAD).
The current released versions of Rack work acceptably with Rails, however Rack HEAD emits warnings, causing test failures.
See rack/rack#2137 for more context. See https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/422 for more details about the specifications.
Detail
Use "422" status code directly in
exception_wrapper.rbto avoid the deprecation warning. This change bypasses symbolic name lookup and thus the deprecation warning, by using the status code directly. We may prefer to change all the symbolic constants to integer values to avoid extra hash lookups. However, it's probably not a performance issue in practice.Handle both
unprocessible_entityandunprocessible_contentinActionDispatch::Responseand the test assertions helper. This ensures compatibility with both symbols going forward, until Rails decides to drop support.Alternatives
I considered the following alternatives:
If there is enough interest in doing it differently, I'd be willing to consider those options.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]