Skip to content

Handle case where script_name is a blank string#51933

Merged
byroot merged 1 commit intorails:mainfrom
zzak:51910
May 31, 2024
Merged

Handle case where script_name is a blank string#51933
byroot merged 1 commit intorails:mainfrom
zzak:51910

Conversation

@zzak
Copy link
Copy Markdown
Member

@zzak zzak commented May 28, 2024

Fixes: #51910

Added regression test:

Failure:
RailtiesTest::EngineTest#test_nested_isolated_engines_should_set_correct_route_module_prefix [test/railties/engine_test.rb:1135]:
--- expected
+++ actual
@@ -1 +1,3 @@
-"/bukkits/awesome/bar"\
+"/awesome/bar"

TBD: where is it being set as ""

wip: add regression test
@byroot byroot merged commit bc56661 into rails:main May 31, 2024
byroot added a commit that referenced this pull request May 31, 2024
Handle case where script_name is a blank string
byroot added a commit that referenced this pull request May 31, 2024
Handle case where script_name is a blank string
@zzak zzak deleted the 51910 branch May 31, 2024 13:24
@adrianthedev
Copy link
Copy Markdown
Contributor

Thank you @zzak and @byroot for pushing this through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression in URL generation in Rails 7.1

3 participants