Don't buffer things that shouldn't be buffered.#51508
Merged
matthewd merged 3 commits intoNov 1, 2024
Merged
Conversation
46caa06 to
39e1787
Compare
c6eeefd to
2add03d
Compare
Member
|
Many tests are broken |
2add03d to
eea9b38
Compare
Contributor
Author
|
Thanks, let me rebase and update again, there has been a bit of churn. |
Contributor
Author
|
There was a good discussion about some of the previous (related) changes here: #24029 |
Contributor
Author
|
@rafaelfranca I think we should merge #52253 first as it fixes some of the core issues with the |
eea9b38 to
97b96df
Compare
a1f29f6 to
d486784
Compare
Contributor
Author
|
I've rebased this on #52253 which we should merge first before this PR. |
42c6548 to
2f10495
Compare
Contributor
Author
|
I've rebased this on #52253 again. |
2f10495 to
a8481b2
Compare
c69f4a1 to
a9b2da0
Compare
a9b2da0 to
2bc2263
Compare
Contributor
Author
|
Thanks @matthewd, really appreciate all your detailed feedback! |
zzak
pushed a commit
to zzak/rails
that referenced
this pull request
Mar 25, 2025
…body-to_ary Don't buffer things that shouldn't be buffered.
Contributor
|
Should this have a changelog entry? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assigning
ActionDispatch::Responsetoself.responsecauses the response body to be buffered (and potentially evaluated multiple times).In both Puma and Falcon, the response is buffered without this change.
cc @willcosgrove