SQLite3 +returning+ documentation additions#50468
Merged
skipkayhil merged 1 commit intorails:mainfrom Dec 28, 2023
Merged
Conversation
… +returning+ option to note that this is available for SQLite3 adapter as well Co-authored-by: OuYangJinTing <ouyangshi95@foxmail.com>
skipkayhil
approved these changes
Dec 28, 2023
Member
|
Thanks for following up! |
skipkayhil
added a commit
that referenced
this pull request
Dec 28, 2023
SQLite3 +returning+ documentation additions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detail
In PR #49290 I failed to update the documentation of the
insert_all,insert_all!, andupsert_allmethods to note that thereturningkeyword argument works for the SQLite3 adapter now.Additional information
This is the only detail from PR #42955 that is left unresolved. Thanks to @OuYangJinTing for reminding me of this detail. @nvasilevski, we can merge this PR and close that one.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]