Support handling Enumerator for non-buffered responses#49616
Merged
rafaelfranca merged 1 commit intorails:mainfrom Oct 13, 2023
Merged
Support handling Enumerator for non-buffered responses#49616rafaelfranca merged 1 commit intorails:mainfrom
rafaelfranca merged 1 commit intorails:mainfrom
Conversation
The downside to this is that we cannot generate ETags for these types of responses, but are assuming that by using an enumerator they don't expect a buffered response to be cacheable. This means you cannot use Enumerator to generate streaming responses. Fixes rails#49588 See also: rails#47092 Co-authored-by: Samuel Williams <samuel.williams@oriontransfer.co.nz>
rafaelfranca
added a commit
that referenced
this pull request
Oct 13, 2023
Support handling Enumerator for non-buffered responses
zzak
added a commit
to zzak/rails
that referenced
this pull request
Oct 13, 2023
There is an inherit complexity with wrapping the Rack body inside Rails which can lead to bugs, like rails#49588. While rails#49616 fixed the bug, it's probably not a good long-term solution. If we go all the way back to 6a89850, we can see this was the original behavior. However, we were trying to solve a separate issue with streaming bodies during disconnect. The `live_stream_test#test_abort_with_full_buffer` test fails in this PR, but I wanted to raise that maybe this could be handled a different way. Also there are two failures in `response_test` which are questions to me: * `ResponseTest#test_[response.to_a].flatten_does_not_recurse_infinitely` * `ResponseTest#test_compatibility_with_Rack::ContentLength` The first seems it is actually resolved upstream, per this comment: rails#47092 (comment) The second means we broke `Rack::ContentLength` and there is a bit on this in rails#44953. FWIW: I'm not proposing this PR exactly, but looking for a path forward and would love some feedback. 🙇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The downside to this is that we cannot generate ETags for these types of responses, but are assuming that by using an enumerator they don't expect a buffered response to be cacheable. This means you cannot use Enumerator to generate streaming responses.
Fixes #49588
See also: #47092