Skip to content

[Action Cable] Stop logging filtered params#47300

Merged
rafaelfranca merged 1 commit intomainfrom
rm-redo-39267
Feb 8, 2023
Merged

[Action Cable] Stop logging filtered params#47300
rafaelfranca merged 1 commit intomainfrom
rm-redo-39267

Conversation

@rafaelfranca
Copy link
Copy Markdown
Member

@rafaelfranca rafaelfranca commented Feb 7, 2023 •
edited
Loading

Redo #39267

Fixes #25088

Co-Autored-By: Kartikey Tanna tannakartikey@gmail.com

@rails-bot rails-bot bot added the actioncable label Feb 7, 2023
pboling
pboling reviewed Feb 8, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@pboling pboling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafaelfranca
[Action Cable] Stop logging filtered params
177b949 
Co-Autored-By: Kartikey Tanna <tannakartikey@gmail.com>
@rafaelfranca rafaelfranca merged commit 2b3c7fc into main Feb 8, 2023
@rafaelfranca rafaelfranca deleted the rm-redo-39267 branch February 8, 2023 18:27
@yykamei yykamei mentioned this pull request Feb 13, 2023
Closed
@hahmed
Copy link
Copy Markdown
Contributor

hahmed commented Feb 15, 2023 •
edited
Loading

This breaks a very simple action cable test for example:

require "test_helper"

class RandomChannelTest < ActionCable::Channel::TestCase
  test "subscribes" do
    subscribe
    assert subscription.confirmed?
  end
end

Maybe this is because the TestServer is part of the tests dir. Not sure if that should be moved into lib (alongside the success adapter). This issue has more details #47377.

@hahmed hahmed mentioned this pull request Feb 15, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eileencodes eileencodes eileencodes approved these changes

+1 more reviewer

@pboling pboling pboling left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

actioncable

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ActionCable] No way to filter out any sensitive data which may be passed as an argument to the remote procedure over ws protocol..

4 participants

@rafaelfranca @hahmed @pboling @eileencodes