[Action Cable] Stop logging filtered params#39267
Closed
tannakartikey wants to merge 2 commits intorails:masterfrom
Closed
[Action Cable] Stop logging filtered params#39267tannakartikey wants to merge 2 commits intorails:masterfrom
tannakartikey wants to merge 2 commits intorails:masterfrom
Conversation
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Contributor
Author
|
@lifo can we re-open this, please, if you think this feature is adding value? |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
@lifo @dhh any chance this could be re-evaluated? This gets flagged as an issue in snyk scans: https://security.snyk.io/vuln/SNYK-RUBY-ACTIONCABLE-20338 |
Member
|
This makes sense to me. @lifo, can you do a review? |
Member
|
@dhh Change looks good to me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-created #25090 as per the comment
This prevents filtered params from being logged.
Fixes #25088
Other Information