This would be useful to have

Sorry for my delay here -- updated my PR, and build should hopefully be passing now 👍

👍 Build is passing

r? @rafaelfranca

@maclover7 That's what I was looking for, do you think this is going to be merged in?

@rafaelfranca cascasca 🍷 😂

Facing an issue similiar to #25088, I came up with a solution using ActionDispatch::Http::ParameterFilter instead of ActionDispatch::Http::FilterParameters, all the code I implemented on my ApplicationCable::Channel class.

Following @rafaelfranca suggestion, this implementation does not depend on a data wrapper class, the filter class used is generic enough and it is already part of Rails 😄.

module ApplicationCable
  class Channel < ActionCable::Channel::Base
    def action_signature(action, data)
      signature = "#{self.class.name}##{action}"
      if (arguments = data.except('action')).any?
        filter = ActionDispatch::Http::ParameterFilter.new(Rails.application.config.filter_parameters)
        signature += "(#{filter.filter(arguments).inspect})"
      end
      signature
    end
  end
end

@rafaelfranca

cc: @maclover7 @arthurdandrea

Do you agree with @arthurdandrea 's approach to addressing #25088 ?
If so, please advise so that @maclover7 / @arthurdandrea can submit a PR with the suggested changes.

I will be happy to volunteer / submit a PR for the same.

Thanks.

Howdy all :) do we have any thoughts on this on moving forward with the PR?

What is the status of this PR? Rails has had ActionCable for a year now, but it still doesn't support filtering.

Any update as of January 10th, 2018 ?

Hi @maclover7 I realize this is old, but the first step to potentially getting this merged is cleaning up the merge conflicts so this can be viewed against latest master and discussed. Thanks for the PR 💝

Would love to see an update on this!

Feel free to take over this PR and implement it. Now we are a generic parameter filter at ActiveSupport::ParameterFilter.

I'm closing this since it is not going to be updated.

@rafaelfranca Is this worth re-submitting? seems to still be an issue

#25090 (comment)