Rename 'Explicit Locals to Strict Locals`#45727
Merged
byroot merged 1 commit intorails:mainfrom Aug 2, 2022
Merged
Conversation
Contributor
Author
|
@byroot 👋🏻 |
seanpdoyle
added a commit
to seanpdoyle/rails
that referenced
this pull request
Jan 24, 2024
Motivation / Background --- Strict Locals support was introduced in [rails#45727][] and announced as part of the [7.1 Release][]. There are several mentions across the Guides, but support is rarely mentioned in the API documentation. Detail ---- This commit adds two test cases to ensure support for splatting additional arguments, and for forbidding block and positional arguments. It also makes mention of strict locals in more places, and links to the guides. [rails#45727]: rails#45727 [7.1 Release]: https://edgeguides.rubyonrails.org/7_1_release_notes.html#allow-templates-to-set-strict-locals
seanpdoyle
added a commit
to seanpdoyle/rails
that referenced
this pull request
Jan 24, 2024
Motivation / Background --- Strict Locals support was introduced in [rails#45727][] and announced as part of the [7.1 Release][]. There are several mentions across the Guides, but support is rarely mentioned in the API documentation. Detail ---- Mention the template short identifier (the pathname, in most cases) as part of the `ArgumentError` message. This commit adds two test cases to ensure support for splatting additional arguments, and for forbidding block and positional arguments. It also makes mention of strict locals in more places, and links to the guides. [rails#45727]: rails#45727 [7.1 Release]: https://edgeguides.rubyonrails.org/7_1_release_notes.html#allow-templates-to-set-strict-locals
seanpdoyle
added a commit
to seanpdoyle/rails
that referenced
this pull request
Jan 24, 2024
Motivation / Background --- Strict Locals support was introduced in [rails#45727][] and announced as part of the [7.1 Release][]. There are several mentions across the Guides, but support is rarely mentioned in the API documentation. Detail ---- Mention the template short identifier (the pathname, in most cases) as part of the `ArgumentError` message. This commit adds two test cases to ensure support for splatting additional arguments, and for forbidding block and positional arguments. It also makes mention of strict locals in more places, and links to the guides. [rails#45727]: rails#45727 [7.1 Release]: https://edgeguides.rubyonrails.org/7_1_release_notes.html#allow-templates-to-set-strict-locals
seanpdoyle
added a commit
to seanpdoyle/rails
that referenced
this pull request
Jan 24, 2024
Motivation / Background --- Strict Locals support was introduced in [rails#45727][] and announced as part of the [7.1 Release][]. There are several mentions across the Guides, but support is rarely mentioned in the API documentation. Detail ---- Mention the template short identifier (the pathname, in most cases) as part of the `ArgumentError` message. This commit adds two test cases to ensure support for splatting additional arguments, and for forbidding block and positional arguments. It also makes mention of strict locals in more places, and links to the guides. [rails#45727]: rails#45727 [7.1 Release]: https://edgeguides.rubyonrails.org/7_1_release_notes.html#allow-templates-to-set-strict-locals
seanpdoyle
added a commit
to seanpdoyle/rails
that referenced
this pull request
Jan 24, 2024
Motivation / Background --- Strict Locals support was introduced in [rails#45727][] and announced as part of the [7.1 Release][]. There are several mentions across the Guides, but support is rarely mentioned in the API documentation. Detail ---- Mention the template short identifier (the pathname, in most cases) as part of the `ArgumentError` message. This commit adds two test cases to ensure support for splatting additional arguments, and for forbidding block and positional arguments. It also makes mention of strict locals in more places, and links to the guides. [rails#45727]: rails#45727 [7.1 Release]: https://edgeguides.rubyonrails.org/7_1_release_notes.html#allow-templates-to-set-strict-locals
seanpdoyle
added a commit
to seanpdoyle/rails
that referenced
this pull request
Jan 25, 2024
Motivation / Background --- Strict Locals support was introduced in [rails#45727][] and announced as part of the [7.1 Release][]. There are several mentions across the Guides, but support is rarely mentioned in the API documentation. Detail ---- Mention the template short identifier (the pathname, in most cases) as part of the `ArgumentError` message. This commit adds two test cases to ensure support for splatting additional arguments, and for forbidding block and positional arguments. It also makes mention of strict locals in more places, and links to the guides. [rails#45727]: rails#45727 [7.1 Release]: https://edgeguides.rubyonrails.org/7_1_release_notes.html#allow-templates-to-set-strict-locals
seanpdoyle
added a commit
to seanpdoyle/rails
that referenced
this pull request
Jan 25, 2024
Motivation / Background --- Strict Locals support was introduced in [rails#45727][] and announced as part of the [7.1 Release][]. There are several mentions across the Guides, but support is rarely mentioned in the API documentation. Detail ---- Mention the template short identifier (the pathname, in most cases) as part of the `ArgumentError` message. This commit adds two test cases to ensure support for splatting additional arguments, and for forbidding block and positional arguments. It also makes mention of strict locals in more places, and links to the guides. [rails#45727]: rails#45727 [7.1 Release]: https://edgeguides.rubyonrails.org/7_1_release_notes.html#allow-templates-to-set-strict-locals
seanpdoyle
added a commit
to seanpdoyle/rails
that referenced
this pull request
Jan 25, 2024
Motivation / Background --- Strict Locals support was introduced in [rails#45727][] and announced as part of the [7.1 Release][]. There are several mentions across the Guides, but support is rarely mentioned in the API documentation. Detail ---- Mention the template short identifier (the pathname, in most cases) as part of the `ArgumentError` message. This commit adds two test cases to ensure support for splatting additional arguments, and for forbidding block and positional arguments. It also makes mention of strict locals in more places, and links to the guides. [rails#45727]: rails#45727 [7.1 Release]: https://edgeguides.rubyonrails.org/7_1_release_notes.html#allow-templates-to-set-strict-locals
viralpraxis
pushed a commit
to viralpraxis/rails
that referenced
this pull request
Mar 24, 2024
Motivation / Background --- Strict Locals support was introduced in [rails#45727][] and announced as part of the [7.1 Release][]. There are several mentions across the Guides, but support is rarely mentioned in the API documentation. Detail ---- Mention the template short identifier (the pathname, in most cases) as part of the `ArgumentError` message. This commit adds two test cases to ensure support for splatting additional arguments, and for forbidding block and positional arguments. It also makes mention of strict locals in more places, and links to the guides. [rails#45727]: rails#45727 [7.1 Release]: https://edgeguides.rubyonrails.org/7_1_release_notes.html#allow-templates-to-set-strict-locals
fractaledmind
pushed a commit
to fractaledmind/rails
that referenced
this pull request
May 13, 2024
Motivation / Background --- Strict Locals support was introduced in [rails#45727][] and announced as part of the [7.1 Release][]. There are several mentions across the Guides, but support is rarely mentioned in the API documentation. Detail ---- Mention the template short identifier (the pathname, in most cases) as part of the `ArgumentError` message. This commit adds two test cases to ensure support for splatting additional arguments, and for forbidding block and positional arguments. It also makes mention of strict locals in more places, and links to the guides. [rails#45727]: rails#45727 [7.1 Release]: https://edgeguides.rubyonrails.org/7_1_release_notes.html#allow-templates-to-set-strict-locals
yoones
pushed a commit
to yoones/rails
that referenced
this pull request
Mar 6, 2025
Motivation / Background --- Strict Locals support was introduced in [rails#45727][] and announced as part of the [7.1 Release][]. There are several mentions across the Guides, but support is rarely mentioned in the API documentation. Detail ---- Mention the template short identifier (the pathname, in most cases) as part of the `ArgumentError` message. This commit adds two test cases to ensure support for splatting additional arguments, and for forbidding block and positional arguments. It also makes mention of strict locals in more places, and links to the guides. [rails#45727]: rails#45727 [7.1 Release]: https://edgeguides.rubyonrails.org/7_1_release_notes.html#allow-templates-to-set-strict-locals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #45602 (comment)