Bump rack to remove ssl? override#42349
Merged
Merged
Conversation
Rack 2.2+ already understands "wss" as being "ssl", so bumping the requirement lets us remove this override and call to super.
eileencodes
approved these changes
Jun 1, 2021
ricardotk002
added a commit
to ricardotk002/rails
that referenced
this pull request
Jun 2, 2021
Following up rails#42349 and rack/rack#1573 the `SERVER_ADDR` header can be dropped, considering that it's not required by the CGI spec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rack 2.2+ understands "wss" as being "ssl", so bumping the requirement lets us remove this override.