Don't skip money's type cast for pluck and calculations#40880
Merged
kamipo merged 1 commit intorails:masterfrom Dec 18, 2020
Merged
Don't skip money's type cast for pluck and calculations#40880kamipo merged 1 commit intorails:masterfrom
kamipo merged 1 commit intorails:masterfrom
Conversation
Returning `OID::Money` column type is accidentally skipped in a query result due to the type is a subclass of `Type::Decimal`. Fixes rails#40860.
kamipo
added a commit
that referenced
this pull request
Dec 18, 2020
Don't skip money's type cast for pluck and calculations
wiegand
added a commit
to utees/rails
that referenced
this pull request
Dec 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Returning
OID::Moneycolumn type is accidentally skipped in a queryresult due to the type is a subclass of
Type::Decimal.Fixes #40860.