Add a note to the docs about existing apps for ActiveStorage public access#40878
Merged
rafaelfranca merged 1 commit intorails:masterfrom Dec 18, 2020
Merged
Conversation
Every existing file needs to be individually updated to have a publicly-readable ACL (at least, this is true of S3 and DigitalOcean Spaces), otherwise the files will fail to load. This bit me when I was trying to introduce `public: true` in my production Rails app. I realize the docs already mention consulting the cloud service docs to ensure that your bucket is "properly configured for public access", but that's rather vague and I didn't really understand the potential issues with individual files' public read permissions from the S3 docs.
rafaelfranca
added a commit
that referenced
this pull request
Dec 18, 2020
…-docs Add a note to the docs about existing apps for ActiveStorage public access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every existing file needs to be individually updated to have a publicly-readable ACL (at least, this is true of S3 and DigitalOcean Spaces), otherwise the files will fail to load.
This bit me when I was trying to introduce
public: truein my production Rails app.I realize the docs already mention consulting the cloud service docs to ensure that your bucket is "properly configured for public access", but that's rather vague and I didn't really understand the potential issues with individual files' public read permissions from the S3 docs.
Just trying to prevent someone else from having the same problem I did :)