Move Spring machinery back to bin files#40527
Merged
rafaelfranca merged 1 commit intorails:masterfrom Nov 24, 2020
Merged
Conversation
ec24697 to
4b845b8
Compare
Follow-up to rails#39746. This shifts the responsibility of loading Spring from `config/boot.rb` back to the relevant bin files. Fixes rails#40518. Closes rails#40521.
4b845b8 to
acc837e
Compare
Contributor
|
This needs to be merged into 6-1-stable as well, the issue is still present on rails 6.1.0.rc2 |
Member
|
@jonathanhefner @rafaelfranca I also see the issue #40518 in Rails 6.1.0.rc2 As a sidenote: after applying changes from this commit by hand, it works fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #39746.
This shifts the responsibility of loading Spring from
config/boot.rbback to the relevant bin files.Fixes #40518.
Closes #40521.