Fix left joins order when merging multiple left joins from different associations#39268
Merged
kamipo merged 1 commit intorails:masterfrom May 13, 2020
Merged
Conversation
…associations rails#38597 is caused by rails#35864. To reproduce this issue, at least it is required four different models and three left joins from different relations. When merging a relation from different model, new stashed (left) joins should be placed before existing stashed joins, but rails#35864 had broken that expectation if left joins are stashed multiple times. This fixes that stashed left joins order as expected. Fixes rails#38597.
kamipo
added a commit
that referenced
this pull request
May 13, 2020
Fix left joins order when merging multiple left joins from different associations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#38597 is caused by #35864.
To reproduce this issue, at least it is required four different models
and three left joins from different relations.
When merging a relation from different model, new stashed (left) joins
should be placed before existing stashed joins, but #35864 had broken
that expectation if left joins are stashed multiple times.
This fixes that stashed left joins order as expected.
Fixes #38597.