Merged
Conversation
Easier to opt out of spring on a per-call basis, guarantees its only run in dev + test envs.
added 4 commits
May 16, 2020 12:33
Just not the insertion into bin/rails and bin/rake
Member
Author
|
On second thoughts, this doesn't offer enough over DISABLE_SPRING=1. Reverting. |
Member
Author
|
And for the protection ensuring that spring only runs in dev+test, we should upstream. This conclusion wasn't good enough: rails/spring#318 |
jonathanhefner
added a commit
to jonathanhefner/rails
that referenced
this pull request
Jun 15, 2020
This partially reverts rails#39225, and folds `boot_with_spring.rb` into `boot.rb`. Fixes rails#39622.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Easier to opt out of spring on a per-call basis, guarantees its only run in dev + test envs.