Make ActionDispatch::Response#content_type behavior configurable#36490
Merged
y-yagi merged 1 commit intorails:masterfrom Jun 21, 2019
Merged
Make ActionDispatch::Response#content_type behavior configurable#36490y-yagi merged 1 commit intorails:masterfrom
ActionDispatch::Response#content_type behavior configurable#36490y-yagi merged 1 commit intorails:masterfrom
Conversation
ac0087d to
f91d6fe
Compare
kamipo
reviewed
Jun 15, 2019
Member
There was a problem hiding this comment.
If load_defaults "5.2" with upgraded Rails 6.0 app, should this option should be false?
Member
There was a problem hiding this comment.
I see, nevermind. New default is false, but for older load_defaults apps, setting true by the line https://github.com/rails/rails/pull/36490/files#diff-182aa02288995070b335f57216738b92R26.
I changed return value of `ActionDispatch::Response#content_type` in rails#36034. But this change seems to an obstacle to upgrading. rails#36034 (comment) Therefore, I restored the behavior of `ActionDispatch::Response#content_type` to 5.2 and deprecated old behavior. Also, made it possible to control the behavior with the config.
y-yagi
added a commit
that referenced
this pull request
Jun 21, 2019
Make `ActionDispatch::Response#content_type` behavior configurable
maximumtiu
added a commit
to maximumtiu/upgrade-rails-workshop
that referenced
this pull request
Aug 13, 2019
rails/rails#36490 caused a deprecation warning to be raised from within Rails. rails/rails#36854 is the fix and has been merged into Rails master. This commit adds a config option as a work-around until Rails 6.0 is officially released.
maximumtiu
added a commit
to maximumtiu/upgrade-rails-workshop
that referenced
this pull request
Aug 13, 2019
rails/rails#36490 caused a deprecation warning to be raised from within Rails. rails/rails#36854 is the fix and has been merged into Rails master. This commit adds a config option as a work-around until Rails 6.0 is officially released.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed return value of
ActionDispatch::Response#content_typein #36034.But this change seems to an obstacle to upgrading. #36034 (comment)
Therefore, I restored the behavior of
ActionDispatch::Response#content_typeto 5.2 and deprecated old behavior. Also, made it possible to control the behavior with the config.