Rename TransactionTimeout to more descriptive LockWaitTimeout#31223
Merged
kamipo merged 1 commit intorails:masterfrom Nov 27, 2017
Merged
Rename TransactionTimeout to more descriptive LockWaitTimeout#31223kamipo merged 1 commit intorails:masterfrom
TransactionTimeout to more descriptive LockWaitTimeout#31223kamipo merged 1 commit intorails:masterfrom
Conversation
Since rails#31129, new error class `StatementTimeout` has been added. `TransactionTimeout` is caused by the timeout shorter than `StatementTimeout`, but its name is too generic. I think that it should be a name that understands the difference with `StatementTimeout`.
Member
|
👍 The previous names make it sound like one should inherit from the other, but they're really not related enough for that to make sense. Clarifying the names seems like a good idea. On a similar note, should we consider |
rafaelfranca
approved these changes
Nov 25, 2017
Member
Author
|
I created new PR #31235 for canceling statement due to user request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #31129, new error class
StatementTimeouthas been added.TransactionTimeoutis caused by the timeout shorter thanStatementTimeout, but its name is too generic. I think that it shouldbe a name that understands the difference with
StatementTimeout.