Add new error class QueryCanceled which will be raised when canceling statement due to user request#31235
Merged
kamipo merged 1 commit intorails:masterfrom Nov 27, 2017
Merged
Conversation
…ng statement due to user request This changes `StatementTimeout` to `QueryCanceled` for PostgreSQL. In MySQL, errno 1317 (`ER_QUERY_INTERRUPTED`) is only used when the query is manually cancelled. But in PostgreSQL, `QUERY_CANCELED` error code (57014) which is used `StatementTimeout` is also used when the both case. And, we can not tell which reason happened. So I decided to introduce new error class `QueryCanceled` closer to the error code name.
rafaelfranca
approved these changes
Nov 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes
StatementTimeouttoQueryCanceledfor PostgreSQL.In MySQL, errno 1317 (
ER_QUERY_INTERRUPTED) is only used when thequery is manually cancelled.
But in PostgreSQL,
QUERY_CANCELEDerror code (57014) which is usedStatementTimeoutis also used when the both case. And, we can not tellwhich reason happened.
So I decided to introduce new error class
QueryCanceledcloser to theerror code name.