Skip to content

Remove redundant return statements#31004

Merged
rafaelfranca merged 1 commit intorails:masterfrom
shuheiktgw:remove_unnecessary_returns
Oct 31, 2017
Merged

Remove redundant return statements#31004
rafaelfranca merged 1 commit intorails:masterfrom
shuheiktgw:remove_unnecessary_returns

Conversation

@shuheiktgw
Copy link

Summary

I just removed redundant return statements like below.

before

def some_method
  return 1
end

after

def some_method
  1
end

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@rafaelfranca rafaelfranca merged commit a8ebd48 into rails:master Oct 31, 2017
kamipo added a commit that referenced this pull request Oct 31, 2017
toshimaru added a commit to toshimaru/rubocop-rails that referenced this pull request Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants