Perf optimization for url_for called w/ Hash#16504
Merged
tenderlove merged 1 commit intorails:masterfrom Aug 14, 2014
Merged
Conversation
Member
Author
|
Here's the raw benchmark/ips My patch is listed a |
Contributor
|
But then we are mutating the given hash which is usually a bad practice. Thoughts? |
Member
|
Ya, I thought we were trying to avoid mutating the parameters. ¯_(ツ)_/¯ |
Benchmarking the existing code:
```ruby
{ :only_path => options[:host].nil? }.merge!(options.symbolize_keys))
```
Against optimized code, that does not require a new hash or a merge:
```ruby
options = options.symbolize_keys
options[:only_path] = options[:host].nil? unless options.key?(:only_path)
options
```
We see a statistically significant performance gain:
Updated to not mutate incoming parameters
Member
|
Yep, while passing options as a hash literal in the method call is a common use case, of course client code may hold a reference. |
Member
Author
|
Updated to not mutate params. Updated screenshot here's the updated numbers: Not as good, but still better. |
tenderlove
added a commit
that referenced
this pull request
Aug 14, 2014
Perf optimization for `url_for` called w/ Hash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmarking the existing code:
Against optimized code, that does not do a merge:
We see a statistically significant performance gain:
Updated to not mutate incoming parameters