-
Notifications
You must be signed in to change notification settings - Fork 386
Merge to Active Record #523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c57c0d3 to
e8a0214
Compare
jeremy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
|
Since this MR, Arel's README (containing valuable code snippets) has been switched to project redirect text in Is this reduction of documentation part of the larger strategy, where usage of Arel is not being encouraged anywhere outside Rails internals? |
|
The documentation is here https://www.rubydoc.info/gems/arel and here https://github.com/rails/arel/tree/v9.0.0 |
|
Thanks for reply. Information in both sites refers to pre-AR inclusion Arel version 9. Is there a plan to keep it updated for v10 and beyond? Or maybe it will eventually appear as README file in |
|
Only what is public API of Arel 10 and beyond will be documented. Right now entire Arel 10 is private API of Active Record |
|
To expand a little: node operations will be documented, in time. But docs that start with |
This is the other half of rails/rails#32097; see that PR for background on why we think this is the best option for ongoing maintenance.
The plan is to release
10.0.0.prewith a dependency onactiverecord >= 6.a, which will work with the 6.0 prereleases, and then finally10.0.0depending onactiverecord >= 6.0.The Arel API will not be changed any more than it would in any other major version bump; libraries that depend on
arelcan reasonably expect to continue working with version 10 to the same degree they would've in previous major releases.Going forward, Arel will be versioned as private Rails API, which means major changes are permitted, without deprecation, in each new
x.y.0release series. (That's already what has been happening in practice: we'll just no longer be incrementing its version to match.)In other words, the major change in version 10 is that Arel's version number is no longer authoritative: to be truly compatible with version 10, you must be controlling for whichever Active Record minor version(s) you've targeted.