Skip to content

Conversation

@matthewd
Copy link
Member

This is the other half of rails/rails#32097; see that PR for background on why we think this is the best option for ongoing maintenance.

The plan is to release 10.0.0.pre with a dependency on activerecord >= 6.a, which will work with the 6.0 prereleases, and then finally 10.0.0 depending on activerecord >= 6.0.

The Arel API will not be changed any more than it would in any other major version bump; libraries that depend on arel can reasonably expect to continue working with version 10 to the same degree they would've in previous major releases.

Going forward, Arel will be versioned as private Rails API, which means major changes are permitted, without deprecation, in each new x.y.0 release series. (That's already what has been happening in practice: we'll just no longer be incrementing its version to match.)

In other words, the major change in version 10 is that Arel's version number is no longer authoritative: to be truly compatible with version 10, you must be controlling for whichever Active Record minor version(s) you've targeted.

@matthewd matthewd self-assigned this Feb 24, 2018
@matthewd matthewd force-pushed the merge-to-activerecord branch from c57c0d3 to e8a0214 Compare February 24, 2018 09:01
Copy link
Member

@jeremy jeremy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@matthewd matthewd merged commit e8a0214 into rails:master Apr 24, 2018
matthewd added a commit that referenced this pull request Apr 24, 2018
This was referenced Apr 25, 2018
@aleksandrs-ledovskis
Copy link

Since this MR, Arel's README (containing valuable code snippets) has been switched to project redirect text in master, and it also hasn't been migrated to ActiveRecord.

Is this reduction of documentation part of the larger strategy, where usage of Arel is not being encouraged anywhere outside Rails internals?

@rafaelfranca
Copy link
Member

The documentation is here https://www.rubydoc.info/gems/arel and here https://github.com/rails/arel/tree/v9.0.0

@aleksandrs-ledovskis
Copy link

Thanks for reply.

Information in both sites refers to pre-AR inclusion Arel version 9. Is there a plan to keep it updated for v10 and beyond? Or maybe it will eventually appear as README file in activerecord/lib/arel?

@rafaelfranca
Copy link
Member

Only what is public API of Arel 10 and beyond will be documented. Right now entire Arel 10 is private API of Active Record

@matthewd
Copy link
Member Author

matthewd commented May 3, 2018

To expand a little: node operations will be documented, in time. But docs that start with Arel::Table.new aren't likely to make a comeback.

@rafaelfranca rafaelfranca mentioned this pull request May 18, 2018
emielvanlankveld added a commit to emielvanlankveld/arel that referenced this pull request Jun 18, 2019
…ord"

This reverts commit aae413b, reversing
changes made to e6ff32c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants