Skip to content

Add support for FILTER clause (SQL:2003)#518

Closed
Envek wants to merge 1 commit intorails:masterfrom
Envek:filter-support
Closed

Add support for FILTER clause (SQL:2003)#518
Envek wants to merge 1 commit intorails:masterfrom
Envek:filter-support

Conversation

@Envek
Copy link

@Envek Envek commented Jan 8, 2018 •
edited
Loading

Closes #460

Currently supported only by PostgreSQL 9.4 and newer.

See:

Example (ActiveRecord):

Model.all.pluck(
  Arel.star.count.as('records_total'),
  Arel.star.count.filter(Model.arel_table[:some_column].not_eq(nil)).as('records_filtered'),
)

@Envek
Add support for FILTER clause (SQL:2003)
0dc449d 
Closes rails#460

Currently supported only by PostgreSQL 9.4 and newer.

See:

 - http://modern-sql.com/feature/filter
 - https://www.postgresql.org/docs/9.4/static/sql-expressions.html#SYNTAX-AGGREGATES

Example (ActiveRecord):

    Model.all.pluck_to_struct(
      Arel.star.count.as('records_total').to_sql,
      Arel.star.count.filter(Model.arel_table[:some_column].not_eq(nil)).as('records_filtered').to_sql,
    )
@rails-bot
Copy link

rails-bot commented Jan 8, 2018

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @sgrif (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@matthewd
Copy link
Member

matthewd commented Apr 25, 2018

Per #523, Arel development is moving to rails/rails.

If this PR is still relevant, please consider reopening it over there.

@matthewd matthewd closed this Apr 25, 2018
@paulwalker
Copy link

paulwalker commented Oct 21, 2020

@Envek can you please consider moving the pull request to rails/rails?

@Envek Envek mentioned this pull request Oct 30, 2020
Merged
@Envek
Copy link
Author

Envek commented Oct 30, 2020

Reopened in rails/rails#40491

@Envek Envek deleted the filter-support branch October 30, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sgrif sgrif

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FILTER clause

5 participants

@Envek @rails-bot @matthewd @paulwalker @sgrif