Add testcase for usage of the programmatic RaidenAPI#434
Closed
konradkonrad wants to merge 7 commits intoraiden-network:masterfrom
Closed
Add testcase for usage of the programmatic RaidenAPI#434konradkonrad wants to merge 7 commits intoraiden-network:masterfrom
konradkonrad wants to merge 7 commits intoraiden-network:masterfrom
Conversation
2d2c78d to
3bb4d26
Compare
9ac4e1c to
74dd0d0
Compare
It seems that we optimized out usage of the programmatic API (`raiden_service.py::RaidenAPI`) from our tests. I added a simple happy case test that shows that we broke it :o
The encoding will instead happen in `RestAPI`.
74dd0d0 to
f9561b6
Compare
Contributor
|
rebased on top of the latest master, are we going to do something with this pr? |
Contributor
|
Ping |
Contributor
|
closing in favor of: #1141 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that we optimized out usage of the programmatic API (
raiden_service.py::RaidenAPI) from our tests.I added a simple happy case test that shows that we broke it :o