bugfix: python's api close was non-functional#1141
Merged
hackaugusto merged 2 commits intoraiden-network:masterfrom Nov 22, 2017
Merged
bugfix: python's api close was non-functional#1141hackaugusto merged 2 commits intoraiden-network:masterfrom
hackaugusto merged 2 commits intoraiden-network:masterfrom
Conversation
Contributor
Author
474b9a7 to
93abad4
Compare
e65b94e to
edb0235
Compare
edb0235 to
f72e594
Compare
Contributor
|
I am reviewing this one |
LefterisJP
approved these changes
Nov 21, 2017
Contributor
LefterisJP
left a comment
There was a problem hiding this comment.
Looks good to me. Some minor comments.
docs/changelog.rst
Outdated
| * :feature:`1097` Added `--gas-price` command line option | ||
| * :feature:`1038` Introduce an upper limit for the ``settle_timeout`` attribute of the netting channel | ||
| * :bug:`1044` Rename ``/connection`` API endpoint to ``/connections`` for consistency | ||
| * :bug:`1138` REST and Python API close did not working if a transfer was made. |
docs/changelog.rst
Outdated
| * :bug:`1011` Remove ``settled`` attribute from the NettingChannel smart contract. | ||
|
|
||
| * :release:`0.1.0 <2017-09-12>` | ||
| * :release:`0.1.0 <2017-09-12>`. |
Contributor
There was a problem hiding this comment.
I think this appears as a section title in the changelog so it should not need a full stop at the end.
raiden/tests/api/test_pythonapi.py
Outdated
| assert channel12.contract_balance == deposit | ||
| assert api1.get_channel_list(token_address, api2.address) == [channel12] | ||
|
|
||
| # there is a channel open, they must be checking each other |
Contributor
There was a problem hiding this comment.
checking -> healthchecking <--- being kind of pedantic here but anyway ..
| amount = 10 | ||
| assert api1.transfer(token_address, amount, api2.address) | ||
|
|
||
| api1.close(token_address, api2.address) |
Contributor
There was a problem hiding this comment.
as we discussed in the chat after you suggestions, add here more asserts after the close for the invariants of the channel state after close()
Contributor
|
PR is approved. Merge as soon as tests pass. |
e939e08 to
816ea0a
Compare
This fixes the python api close, add a regression test for that problem and add general tests for it.
816ea0a to
33317be
Compare
This was referenced Nov 22, 2017
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the python api close, add a regression test for that problem
and add general tests for it.