Support DeepSeek v3.2#963
Open
zianglih wants to merge 18 commits intoradixark:mainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for DeepSeek-V3.2 models, including necessary configuration patching, tokenizer handling, and adjustments to RoPE interleave logic in the Megatron-to-HF conversion and model plugins. Review feedback highlights the need to replace hardcoded model dimensions (e.g., 128, 64) with dynamic configuration values and to use field(default_factory=...) for dataclass default values to ensure proper execution.
ziang-and
pushed a commit
to zianglih/miles
that referenced
this pull request
Apr 9, 2026
ziang-and
pushed a commit
to zianglih/miles
that referenced
this pull request
Apr 10, 2026
30 tasks
ziang-and
pushed a commit
to zianglih/miles
that referenced
this pull request
Apr 11, 2026
zianglih
commented
Apr 14, 2026
| "You are using too many GPUs for this conversion." | ||
| assert args.pipeline_model_parallel_size <= args.num_layers, ( | ||
| f"Pipeline model parallel size {args.pipeline_model_parallel_size} must be less than or equal to " | ||
| f"number of layers {args.num_layers}." |
Contributor
Author
There was a problem hiding this comment.
This is to relax the assertion to unblock conversion.
ziang-and
pushed a commit
to zianglih/miles
that referenced
this pull request
Apr 19, 2026
Contributor
|
Thanks @zianglih! Could you share which docker image and sgLang commit you used for testing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@HumansAnd
indexer_rope_interleaveinto args--freeze-indexerarg