Skip to content

Make the CI fail when testing on JRuby fails#34

Merged
ioquatix merged 1 commit intorack:mainfrom
jcmfernandes:drop-experimental-flag-from-jruby
Jan 19, 2024
Merged

Make the CI fail when testing on JRuby fails#34
ioquatix merged 1 commit intorack:mainfrom
jcmfernandes:drop-experimental-flag-from-jruby

Conversation

@jcmfernandes
Copy link
Contributor

@jcmfernandes jcmfernandes commented Jan 17, 2024

This is a proposal in the form of a PR.

EDIT:
#32 must be merged first.

@ioquatix ioquatix force-pushed the drop-experimental-flag-from-jruby branch from 5eda9e3 to 0f8cca3 Compare January 17, 2024 12:31
@ioquatix ioquatix self-assigned this Jan 17, 2024
@ioquatix
Copy link
Member

What is your goal with this PR?

@jcmfernandes
Copy link
Contributor Author

What is your goal with this PR?

Treat JRuby as a first-class citizen.

Now, in my opinion, JRuby has enough traction to warrant treating it like any other CRuby version. This is just an opinion. In the absence of a formal compatibility list, this change doesn't imply that JRuby is supported.

@ioquatix ioquatix force-pushed the drop-experimental-flag-from-jruby branch from 0f8cca3 to ddb43cb Compare January 19, 2024 02:31
@ioquatix ioquatix merged commit 93a5e5a into rack:main Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants