Conversation
There's no need for it.
Contributor
Author
|
Some tests are failing on jruby because, unlike cruby, |
Member
|
It would help a lot to split out cosmetic changes into separate PRs. i.e. the missing file, syntax/formatting changes, etc. |
Contributor
|
Unfortunately this PR brought jruby/jruby-openssl#290 for JRuby users |
Contributor
Author
Thanks for reporting this. I opened #32. |
ioquatix
pushed a commit
that referenced
this pull request
Jan 4, 2025
ioquatix
pushed a commit
that referenced
this pull request
May 6, 2025
ioquatix
pushed a commit
that referenced
this pull request
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As explained in #22, I know I'm not the first bringing this up, but almost 6 years have passed since that thread was created, and, IMHO, the landscape has changed enough to consider once again adding AEAD encryption to rack-session.
Here's a benchmark I wrote:
and got these results: