-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Introduce Rack::VERSION.
#2199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Rack::VERSION.
#2199
Conversation
c21c6ca to
e83bf89
Compare
e83bf89 to
82f846b
Compare
|
Is it worth to deprecate |
|
I'm okay with considering different options (e.g. do nothing, or not deprecating it), however it will be between 6-12 months before this is actually released, and then there will be at least another 6-12 months for another release which actually removes it. I don't think that's unreasonable. |
|
Yeah, I know it will probably be a while still until this is actually released. The thought that my compatibility code I wrote explicitly to avoid deprecations starts throwing deprecations doesn't sound like the most pleasant experience to me. Since this is so simple, I'd prefer for this to stay around deprecation-less for a while yet, until Rack 4 (or something else far in the future where libraries can reasonably be assumed to no longer support Rack < 3.2) so people don't have to worry about I know there's |
jeremyevans
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @Earlopain , that we don't need to deprecate RELEASE.
177d151 to
c29b3a4
Compare
jeremyevans
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change requested, then this should be good to merge.
da8384a to
7da6f44
Compare
Rack::RELEASE might be removed or deprecated from Rack 4 (details: rack/rack#2199)
No description provided.