Remove deprecated methods and mark values_at as deprecated.#2183
Merged
Conversation
8f8c3d5 to
19460a6
Compare
19460a6 to
9b76c15
Compare
jeremyevans
approved these changes
May 31, 2024
jeremyevans
left a comment
Contributor
There was a problem hiding this comment.
I disagree with your reasons for doing this, as I've explained in #1879. However, I think the change itself is fine. values_at is not a good name because there is no indication it operates on params (I would expect it to operate on env given the name).
emon
added a commit
to emon/omniauth-identity
that referenced
this pull request
Aug 13, 2024
use req.params[] instead of req[], which was removed in rack 3.1.0 rack/rack#2183
This was referenced Aug 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1879 for context.