Allow passing through same_site option to session cookie when using Rack::Session::Cookie middleware#1543
Merged
jeremyevans merged 1 commit intoFeb 4, 2020
Conversation
jeremyevans
requested changes
Feb 1, 2020
jeremyevans
left a comment
Contributor
There was a problem hiding this comment.
Other than one issue in the specs mentioned in an earlier note, I think this looks good and I plan to merge it unless another core team member objects.
…ack::Session::Cookie middleware Recently, rack added support for SameSite=None cookies: rack#1358 However there is currently no way to set these cookies using the Rack::Session::Cookie middleware without monkeypatching. This pull request allows setting the SameSite value either by direct, literal passthrough to the add_cookie_to_header method, or by passing a callable. The callable option is required because some browsers are incompatible with some values of the header, so it needs to be [different per-browser](https://www.chromium.org/updates/same-site/incompatible-clients). Static usage: ```ruby use Rack::Session::Cookie, secret: 'supersecret', same_site: :none ``` Dynamic usage: ```ruby use Rack::Session::Cookie, secret: 'supersecret', same_site: lambda { |req, res| SameSite.value(req.user_agent) } ```
4868ea4 to
8fee2fa
Compare
jeremyevans
approved these changes
Feb 1, 2020
jeremyevans
left a comment
Contributor
There was a problem hiding this comment.
Looks good. I'll wait for a few days to see if another core team member has any feedback. Assuming none, I'll merge.
kamipo
added a commit
to kamipo/rack
that referenced
this pull request
Feb 10, 2020
Follow up of rack#1543.
bf4
referenced
this pull request
in rails/rails
Jan 25, 2021
…e_site_protection Add documentation of Proc usage for SameSite property to configuring.md Address PR comments Co-authored-by: Adrianna Chang <adrianna.chang@shopify.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently, rack added support for SameSite=None cookies
However there is currently no way to set these cookies using the Rack::Session::Cookie
middleware without monkeypatching.
This pull request allows setting the SameSite value either by direct, literal
passthrough to the add_cookie_to_header method, or by passing a callable.
The callable option is required because some browsers are incompatible with
some values of the header, so it needs to be different per-browser.
Static usage:
Dynamic usage: