Conversation
Responses are not arrays, so we should not allow them to be implicitly coerced to an array. If you would like you response to be converted to an array, you must explicitly do it with the `to_a` method. This also prevents creation of unnecessary body proxies
Member
Author
|
I was able to confirm that without removing this line the |
Contributor
|
Looks like this will break Grape, ruby-grape/grape#1955. I haven't dug deep here, @dnesteryuk can probably provide an explanation. |
|
It does indeed break Grape; This issue explains the effect on Grape: ruby-grape/grape#1966 |
dentarg
added a commit
to dentarg/gists
that referenced
this pull request
Jun 4, 2020
Not calling #finish worked up until rack 2.1.0: rack/rack@72959eb rack/rack#1453 https://github.com/rack/rack/blob/v2.2.2/lib/rack/response.rb#L6-L17 Response#finish has always been there: rack/rack@7ed819a#diff-10b933d2c1fdc82ceecade456c64e1c2
ch1c0t
added a commit
to ch1c0t/hobby
that referenced
this pull request
Mar 26, 2021
This was referenced Apr 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Responses are not arrays, so we should not allow them to be implicitly
coerced to an array. If you would like you response to be converted to
an array, you must explicitly do it with the
to_amethod.This also prevents creation of unnecessary body proxies
refs #419