Fix issues with multiple src and dest queue args#8356
Merged
michaelklishin merged 2 commits intomainfrom Mar 5, 2026
Merged
Conversation
dcc7718 to
2fcff31
Compare
2fcff31 to
37fe49c
Compare
37fe49c to
bbdd717
Compare
Fixes #8323 Step 1: modify test so it throws the same error
bbdd717 to
8a6e35d
Compare
mergify bot
pushed a commit
that referenced
this pull request
Mar 5, 2026
(cherry picked from commit 4567c3c)
michaelklishin
added a commit
that referenced
this pull request
Mar 6, 2026
Fix issues with multiple src and dest queue args (backport #8356)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8323
Follow-up to #2802
The
src-queue-argsanddest-queue-argsshovel parameters were validated usingrabbit_parameter_validation:proplist/3, which calls validators asFun(Key, Value). However, the validators fromrabbit_amqqueue:declare_args/0expect to be called asFun({Type, Value}, FullTable)— with an AMQP-typed value and the full args table for cross-referencing (e.g.check_dlxrk_arg/2looks upx-dead-letter-exchangein the table).This mismatch caused crashes when multiple args were specified, such as
x-dead-letter-exchange+x-dead-letter-routing-keyon a quorum queue, orx-max-ageon a stream queue.The fix converts the input to an AMQP table and validates using the same convention as
rabbit_amqqueue:check_arguments_type_and_value/3.