Skip to content

Force tracing plugin to use UTF-8 encoding instead of default Latin1. (backport #15439)#15441

Merged
michaelklishin merged 1 commit intov4.2.xfrom
mergify/bp/v4.2.x/pr-15439
Feb 10, 2026
Merged

Force tracing plugin to use UTF-8 encoding instead of default Latin1. (backport #15439)#15441
michaelklishin merged 1 commit intov4.2.xfrom
mergify/bp/v4.2.x/pr-15439

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify bot commented Feb 10, 2026

Entire trace record will be rejected if payload contains any non-Latin1 character, which leads to missed trace records despite of successful processing of the messages themselves.

Proposed Changes

Tracing is used to monitor message exchange, and it is really unclear why the system works but specific messages are not presented in the trace files.

The entire project works fine with UTF-8 encoded payload, including official Docker images preconfigured to use UTF-8 as a system wide locale, so it is obvious to use UTF-8 encoding by default in the tracing plugin,

Additional options (like drop down list with encodings to use by tracing plugin) were not implemented as it is not tracing plugin feature, but a missing of support in the tracing plugin of the specified encoding, despite it is used by server itself.

No related issues were found.

No unit tests were implemented for this change.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
This is simply a reminder of what we are going to look for before merging your code.

  • Mandatory: I (or my employer/client) have have signed the CA (see https://github.com/rabbitmq/cla)
  • I have read the CONTRIBUTING.md document
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

It is a retry for PR #15133
CLA is signed.


This is an automatic backport of pull request #15439 done by Mergify.

Entire trace record will be rejected if payload contains any
non-Latin1 character, which leads to missed trace records despite of
successful processing of the messages themselves.

(cherry picked from commit 718f640)
@michaelklishin michaelklishin added this to the 4.2.4 milestone Feb 10, 2026
@michaelklishin michaelklishin merged commit a42382f into v4.2.x Feb 10, 2026
288 checks passed
@michaelklishin michaelklishin deleted the mergify/bp/v4.2.x/pr-15439 branch February 10, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants