Force tracing plugin to use UTF-8 encoding instead of default Latin1.#15133
Closed
idokka wants to merge 3 commits intorabbitmq:mainfrom
Closed
Force tracing plugin to use UTF-8 encoding instead of default Latin1.#15133idokka wants to merge 3 commits intorabbitmq:mainfrom
idokka wants to merge 3 commits intorabbitmq:mainfrom
Conversation
Entire trace record will be rejected if payload contains any non-Latin1 character, which leads to missed trace records despite of successful processing of the messages themselves.
Collaborator
|
@idokka thank you for taking the time. This seems to be your first contribution to RabbitMQ. Please sign our contributor CLA before we proceed. |
Contributor
Author
|
Will check test fails and fix. Thanks for triggering the test job. |
As `prim_file:open/2` does not support encoding the text record will be encoded by `io_lib:bformat/2` in place.
Collaborator
|
By merging |
Contributor
Author
|
Sorry, will redo and make better and deeper local testing. |
Collaborator
|
This PR is not mergeable (or more specifically, not automatically backportable) due to the |
12 tasks
Merged
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Entire trace record will be rejected if payload contains any non-Latin1 character, which leads to missed trace records despite of successful processing of the messages themselve.
Proposed Changes
Tracing is used to monitor message exchange, and it is really unclear why the system works but specific messages are not presented in the trace files.
The entire project works fine with UTF-8 encoded payload, including official Docker images preconfigured to use UTF-8 as a system wide locale, so it is obvious to use UTF-8 encoding by default in the tracing plugin,
Additional options (like drop down list with encodings to use by tracing plugin) were not implemented as it is not tracing plugin feature, but a missing of support in the tracing plugin of the specified encoding, despite it is used by server itself.
No related issues were found.
No unit tests were implemented for this change.
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply(non-breaking change which fixes issue #NNNN)Checklist
Put an
xin the boxes that apply.You can also fill these out after creating the PR.
This is simply a reminder of what we are going to look for before merging your code.
CONTRIBUTING.mddocument