Management UI: Add autocomplete, autofocus and label linking to input at login page.#15398
Merged
michaelklishin merged 1 commit intorabbitmq:mainfrom Feb 5, 2026
Merged
Conversation
Collaborator
Contributor
Author
|
@michaelklishin done! |
Contributor
Author
|
the selenium error is related to PR from fork
the other failure seems not related (maybe flaky test?) |
Collaborator
|
Yup, out of the thousands tests in our suites, some are flaky. Selenium tests require access to a secret. |
michaelklishin
approved these changes
Feb 5, 2026
michaelklishin
added a commit
that referenced
this pull request
Feb 5, 2026
Management UI: Add autocomplete, autofocus and label linking to input at login page. (backport #15398)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The only purpose of the login page is to put login as password thus first action is to get username focus. This PR adds auto focus to this input. Also as a side effect updates the autocomplete attributes and adds ids to inputs to link labels properly to input, which makes label clickable to focus the input also (just minor tweak).
UI should be visually 100% the same.