Add test enabling all feature flags with exchange logger#15294
Add test enabling all feature flags with exchange logger#15294michaelklishin merged 1 commit intomainfrom
Conversation
|
This test should be backported to |
7d283b3 to
e50a6bf
Compare
|
thank you |
Add test enabling all feature flags with exchange logger (backport #15294)
Thank you. Enabling feature flag |
I think my colleagues might have noticed it, but we already noted the workaround that we had to disable the log exchange when enabling FFs after an upgrade to 3.13.x so that stopped any further investigation. |
This corresponds to the comments I would have made to #15294, but this pull request was merged before I had a chance to review it. * Break long lines. This applies to a few long lines that were already there before #15294. * Do not -import() functions as this makes the code more difficult to read and maintain. While here, fix the copyright line: the initial year was incorrect and the line was also too long.
Thank you for letting us know. Yes, disabling the log exchange temporarily is a valid workaround (as long as some other form of logging, e.g. to stdout or to a file is configured). |
This corresponds to the comments I would have made to #15294, but this pull request was merged before I had a chance to review it. * Break long lines. This applies to a few long lines that were already there before #15294. * Do not -import() functions as this makes the code more difficult to read and maintain. While here, fix the copyright line: the initial year was incorrect and the line was also too long. (cherry picked from commit fcd5e9b) # Conflicts: # deps/rabbit/test/logging_SUITE.erl
This corresponds to the comments I would have made to #15294, but this pull request was merged before I had a chance to review it. * Break long lines. This applies to a few long lines that were already there before #15294. * Do not -import() functions as this makes the code more difficult to read and maintain. While here, fix the copyright line: the initial year was incorrect and the line was also too long. (cherry picked from commit fcd5e9b)
This corresponds to the comments I would have made to #15294, but this pull request was merged before I had a chance to review it. * Break long lines. This applies to a few long lines that were already there before #15294. * Do not -import() functions as this makes the code more difficult to read and maintain. While here, fix the copyright line: the initial year was incorrect and the line was also too long.
Add a test enabling all stable feature flags with exchange logging enabled.
This is a more general test case for #11652 that should catch all future feature flag issues when
rabbit_ff_controllerpublishes a message.Relates
#11652 #14069 #14796