Skip to content

Fix up oauth2_client ssl options#14917

Merged
michaelklishin merged 1 commit intorabbitmq:mainfrom
amazon-mq:lukebakken/oauth2_client-cacerts
Nov 10, 2025
Merged

Fix up oauth2_client ssl options#14917
michaelklishin merged 1 commit intorabbitmq:mainfrom
amazon-mq:lukebakken/oauth2_client-cacerts

Conversation

@lukebakken
Copy link
Copy Markdown
Collaborator

This uses the same technique as PR #12557 and #12564 to ensure that when neither cacerts nor cacertfile are set, the system certs are used.

@lukebakken lukebakken self-assigned this Nov 7, 2025
@lukebakken lukebakken marked this pull request as ready for review November 7, 2025 23:33
@michaelklishin michaelklishin added this to the 4.3.0 milestone Nov 8, 2025
@michaelklishin
Copy link
Copy Markdown
Collaborator

Thank you, @lukebakken.

I'll wait for @MarcialRosales' approval before merging.

This uses the same technique as PR rabbitmq#12557 and rabbitmq#12564 to ensure that when
neither `cacerts` nor `cacertfile` are set, the system certs are used.
@lukebakken lukebakken force-pushed the lukebakken/oauth2_client-cacerts branch from 7110ccc to c481f39 Compare November 10, 2025 15:46
@michaelklishin michaelklishin merged commit 4308d4b into rabbitmq:main Nov 10, 2025
574 of 575 checks passed
michaelklishin added a commit that referenced this pull request Nov 10, 2025
Fix up `oauth2_client` ssl options (backport #14917)
@lukebakken lukebakken deleted the lukebakken/oauth2_client-cacerts branch November 10, 2025 19:22
Copy link
Copy Markdown
Contributor

@MarcialRosales MarcialRosales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all looks good. Thanks @lukebakken for fixing it !

lukebakken pushed a commit to lukebakken/rmq-rabbitmq-server that referenced this pull request Mar 17, 2026
…ient-cacerts

Fix up `oauth2_client` ssl options

(cherry picked from commit 4308d4b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants