QQ: when invoking drain only shut down small batches at a time#14401
Merged
michaelklishin merged 2 commits intomainfrom Aug 22, 2025
Merged
QQ: when invoking drain only shut down small batches at a time#14401michaelklishin merged 2 commits intomainfrom
michaelklishin merged 2 commits intomainfrom
Conversation
5a0eb5b to
a2e15c5
Compare
f4bc9a2 to
16b7daa
Compare
Then wait for elections to complete before shutting further members down. This should help avoid election storms when enabling maintenance mode. Transfer khepri before queues to ensure meta data store is ready to accept pid updates. Some other state related tweaks.
16b7daa to
87154f9
Compare
michaelklishin
approved these changes
Aug 22, 2025
mkuratczyk
approved these changes
Aug 22, 2025
Contributor
mkuratczyk
left a comment
There was a problem hiding this comment.
This works for me but only if I increase the AWAIT_TIMEOUT in ra_log_segment_writer. I think we should increase that timeout as well, otherwise with enough QQs, node startup fails.
Collaborator
|
@mkuratczyk fair enough. What |
michaelklishin
added a commit
to rabbitmq/ra
that referenced
this pull request
Aug 24, 2025
Per discussion in rabbitmq/rabbitmq-server#14401
Collaborator
|
For example, this PR doubles the aforementioned timeout rabbitmq/ra#556. |
Merged
Collaborator
|
@Mergifyio backport |
❌ No backport have been createdDetails
GitHub error: |
michaelklishin
added a commit
that referenced
this pull request
Aug 26, 2025
This was referenced Aug 26, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Then wait for elections to complete before shutting further
members down.
This should help avoid election storms when enabling maintenance
mode.
Transfer khepri before queues to ensure meta data store is
ready to accept pid updates.
Some other state related tweaks.