Do not clear pending if points to the checkpoint#602
Merged
michaelklishin merged 1 commit intorabbitmq:mainfrom Mar 26, 2026
Merged
Do not clear pending if points to the checkpoint#602michaelklishin merged 1 commit intorabbitmq:mainfrom
michaelklishin merged 1 commit intorabbitmq:mainfrom
Conversation
When a new checkpoint write is in progress and release_cursor fires promote_checkpoint, the pending field gets overwritten, and the subsequent checkpoint completion clobbers the snapshot's pending state.
michaelklishin
approved these changes
Mar 26, 2026
Contributor
jimsynz
pushed a commit
to jimsynz/neonfs
that referenced
this pull request
Mar 29, 2026
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [ra](https://hex.pm/packages/ra) ([source](https://github.com/rabbitmq/ra)) | prod | patch | `3.1.0` → `3.1.2` | --- ### Release Notes <details> <summary>rabbitmq/ra (ra)</summary> ### [`v3.1.2`](https://github.com/rabbitmq/ra/releases/tag/v3.1.2) [Compare Source](rabbitmq/ra@v3.1.1...v3.1.2) #### What's Changed - `gen_batch_server` was bumped to `0.9.2` to significantly reduce the risk of an [OOM scenario](rabbitmq/gen-batch-server#27) that affects Ra-based systems **Full Changelog**: <rabbitmq/ra@v3.1.1...v3.1.2> ### [`v3.1.1`](https://github.com/rabbitmq/ra/releases/tag/v3.1.1) [Compare Source](rabbitmq/ra@v3.1.0...v3.1.1) #### What's Changed - Use the Unicode translation modifier to log server IDs and cluster names by [@​the-mikedavis](https://github.com/the-mikedavis) in [#​599](rabbitmq/ra#599) - Export `ra:membership()` type by [@​the-mikedavis](https://github.com/the-mikedavis) in [#​603](rabbitmq/ra#603) - Do not clear pending if points to the checkpoint by [@​deadtrickster](https://github.com/deadtrickster) in [#​602](rabbitmq/ra#602) - Fix doubly-wrapped log entries after sparse write and recovery by [@​ansd](https://github.com/ansd) in [#​601](rabbitmq/ra#601) **Full Changelog**: <rabbitmq/ra@v3.1.0...v3.1.1> </details> --- ### Configuration 📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) in timezone Pacific/Auckland, Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) in timezone Pacific/Auckland. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My45MC4xIiwidXBkYXRlZEluVmVyIjoiNDMuOTAuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUiXX0=--> Reviewed-on: https://harton.dev/project-neon/neonfs/pulls/84 Co-authored-by: Renovate Bot <bot@harton.nz> Co-committed-by: Renovate Bot <bot@harton.nz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Rav3 Tanzu DQ's log writer errors as soon as snapshot is requested. For example,
initially I thought it is due to the [] being the default for live indexes, but looks like it is due to some race here, in complete_snapshot.