ra_server: Evaluate member promotion in #install_snapshot_result{}#584
Merged
michaelklishin merged 1 commit intomainfrom Mar 3, 2026
Merged
ra_server: Evaluate member promotion in #install_snapshot_result{}#584michaelklishin merged 1 commit intomainfrom
#install_snapshot_result{}#584michaelklishin merged 1 commit intomainfrom
Conversation
Contributor
|
make sense! thanks |
945ac4d to
fabff69
Compare
59b288f to
d16be00
Compare
Currently, promotable members can get "stuck" as promotable until the
next command is appended if they join the cluster and only install a
snapshot from the leader. We can evaluate promoting the peer when
handling `#install_snapshot_result{}` to ensure the member becomes a
voter.
d16be00 to
e373a64
Compare
michaelklishin
approved these changes
Mar 2, 2026
michaelklishin
added a commit
that referenced
this pull request
Mar 3, 2026
…omote
ra_server: Evaluate member promotion in `#install_snapshot_result{}` (backport #584)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, promotable members can get "stuck" as promotable until the next command is appended if they join the cluster and only install a snapshot from the leader. We can evaluate promoting the peer when handling
#install_snapshot_result{}to ensure the member becomes a voter.I haven't been able to reproduce this yet but I've seen this in the wild with RabbitMQ 4.2.0:
[ {"Node Name":"rabbit@<node1>","Raft State":"follower","Membership":"promotable","Last Log Index":219,"Last Written":219,"Last Applied":219,"Commit Index":219,"Snapshot Index":219,"Term":1,"Machine Version":7} ,{"Node Name":"rabbit@<node2>","Raft State":"follower","Membership":"voter","Last Log Index":219,"Last Written":219,"Last Applied":219,"Commit Index":219,"Snapshot Index":219,"Term":1,"Machine Version":7} ,{"Node Name":"rabbit@<node3>","Raft State":"leader","Membership":"voter","Last Log Index":219,"Last Written":219,"Last Applied":219,"Commit Index":219,"Snapshot Index":219,"Term":1,"Machine Version":7} ]I'll look at writing a test...✔️