Update init_it to match modern gen_server:init_it#24
Merged
michaelklishin merged 1 commit intorabbitmq:masterfrom Mar 18, 2026
Merged
Update init_it to match modern gen_server:init_it#24michaelklishin merged 1 commit intorabbitmq:masterfrom
michaelklishin merged 1 commit intorabbitmq:masterfrom
Conversation
This change roughly syncs the init_it with gen_server's. The nice part
of this is that we can now return `ignore` and `{error, Reason}` which
are supported by `gen_server` but not `gen_batch_server`. `ignore` might
be useful for `ra_log_wal` when there is no available disk space.
Contributor
|
@the-mikedavis thank you. Good idea. We need to bump Erlang/OTP minimum to 26, though, that seems to be the first version Plus some type specs were not updated. I have a follow-up PR in the works that further narrows the gap with modern |
michaelklishin
added a commit
that referenced
this pull request
Mar 18, 2026
Upgrade to match modern `gen_server` (continuation of #24)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change roughly syncs the init_it with gen_server's. The nice part of this is that we can now return
ignoreand{error, Reason}which are supported bygen_serverbut notgen_batch_server.ignoremight be useful forra_log_walwhen there is no available disk space.