fix: contract gas input devex #714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62a149c to
222a07c
Compare
Daanvdplas
commented
Nov 5, 2025
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## daan/fix-contract_interaction #714 +/- ##
=================================================================
+ Coverage 76.96% 77.00% +0.04%
=================================================================
Files 111 111
Lines 25360 25402 +42
Branches 25360 25402 +42
=================================================================
+ Hits 19519 19562 +43
- Misses 3775 3776 +1
+ Partials 2066 2064 -2
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
moliholy
reviewed
Nov 5, 2025
| /// call. | ||
| #[arg(name = "gas", short, long)] | ||
| /// DEPRECATED use `--manual-weight <REF_TIME> <PROOF_SIZE>` instead, removed in v0.13.0. | ||
| #[arg(name = "gas", short, long, conflicts_with = "manual_weight", requires = "proof_size")] |
Collaborator
There was a problem hiding this comment.
This one (and the other deprecated ones) should be marked with #[deprecated].
Daanvdplas
added a commit
that referenced
this pull request
Nov 7, 2025
* fix: chain & contract manual interaction * Update crates/pop-cli/src/commands/call/chain.rs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * refactor: resolve funct args * fix: contract gas input devex (#714) * refactor: manual weight * fix: docs and issue tommy * fix: ci * Update crates/pop-cli/src/commands/call/contract.rs * Update crates/pop-cli/src/commands/call/contract.rs * Update crates/pop-cli/src/commands/call/contract.rs * Update crates/pop-cli/src/commands/call/contract.rs * Update crates/pop-cli/src/commands/call/contract.rs * fix: ci * fix: deprecated * fix: tests deprecated error --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This was referenced Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #612