Accommodate R-devel changes#841
Conversation
|
Thank you for the PR, it’s really appreciated. That will save me hours. Regarding the URL, there’s nothing I can do. The issue is known and the URLs are correct; the server is simply rejecting CRAN (and likely other bot-like requests). As for |
|
Ok for the links it is now a 404. Different issue. The links were actually invalided. |
|
Makes sense for SETLENGTH. I have not had a need to reduce vector size (apart from the obious 'copy-and-destroy-old-one') but like you I am aware that the Glad the PR worked for you. I once again learned something new about ALTREP. |
|
Oh and by the way: You could generalize the |
|
BTW regarding that use of
|
|
Hi @Jean-Romain : I am hearning from @kurthornik that CRAN would really like an updated Rcpp package but this, as discussed here via this PR, would break over your package lidR. I am monitoring incoming/ at CRAN (my function ciw::ciw() aka makes that easy) and it is up to 97 packages now but yours it not yet part of it. Could you be of assistance here and upload it? Else I can ask CRAN to override. Many thanks! |
|
I'll release today or tomorrow. Is everything ok in the current state on github? |
|
Do you mean with Rcpp? Yes. It required one other package to change, it is also now in incoming. What is in the Rcpp repo will be 1.1.1 once @kurthornik and I dot all i-s and cross all t-s on URLs. Code will not change -- Rcpp 1.1.0.14 as committed will be the same as 1.1.1. A few purely cosmetic README and vignette and .bib changes in the air. Thanks for the prompt update of lidR -- much appreciated. |
|
sent on CRAN. Thanks |
|
So it did not pass CRAN pretest on windows despite is passed on win-builder |
|
That is me / that is us but it is circular (and "expected"):
You can safely explain this away to them. It is just a NOTE. The note disappears once Rcpp 1.1.1 arrives. But in order to get Rcpp 1.1.1 onto CRAN we need the updated lidR to survive the change of return value from nrow() from int to R_xlen_t which upsets your std::min() in your CRAN version. Makes sense? PS Also 'NOTE' != 'WARNING', and is generally not a blocker. And it really isn't your code. |
|
Ok I understand. So I replied to the CRAN. I hope it gonna pass with manual validation. I know that a NOTE is not a WARNING but usually a rejection is a rejection even with a NOTE. But the explantions sound strong 😄 |
|
Yes. I wrote a little helper package |
|
>>>> Dirk Eddelbuettel writes:
Thanks. Apparently Uwe did not get to pulling the Rcpp-with-no-ATTRIB
hotfix before starting the windows checks. I just triggered the
rechecks.
…-k
# eddelbuettel left a comment (r-lidar/lidR#841)
Yes. I wrote a little helper package ciw (== CRAN Incoming Watcher) so that
ciw::ciw() shows (quickly, easily) what is in the queue and lidR got moved to
section 'archive/' which is puzzling. I hope this gets straightened out -- it
also happens to some packages of mine (e.g. Rcpp has one old grandfathered
exception but it still comes up each time -- sigh).
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.*Message ID: <r-lidar/lidR/
***@***.***>
|
|
>>>> Kurt Hornik writes:
And meanwhile on CRAN ...
…-k
>>>> Dirk Eddelbuettel writes:
Thanks. Apparently Uwe did not get to pulling the Rcpp-with-no-ATTRIB
hotfix before starting the windows checks. I just triggered the
rechecks.
-k
> # eddelbuettel left a comment (r-lidar/lidR#841)
> Yes. I wrote a little helper package ciw (== CRAN Incoming Watcher) so that
> ciw::ciw() shows (quickly, easily) what is in the queue and lidR got moved to
> section 'archive/' which is puzzling. I hope this gets straightened out -- it
> also happens to some packages of mine (e.g. Rcpp has one old grandfathered
> exception but it still comes up each time -- sigh).
> —
> Reply to this email directly, view it on GitHub, or unsubscribe.
> You are receiving this because you were mentioned.*Message ID: <r-lidar/lidR/
> ***@***.***>
|
|
On its way on CRAN. Thanks |
|
All good -- thanks so much for the prompt update! |
Salut @Jean-Romain,
As discussed the other day over in lasR repo in this org, Luke Tierney is tightening the R API. In R's move away from ATTRIB() we changed how we compute the number of rows in a data.frame (it is easier and better now) but also changed to returning a larger R_xlen_t. It turns out your file src/knn.cpp is the only one using this in a type-checking context such as the
std::min()so it needs a cast.When looking at this I noticed CRAN is also nagging you about ATTRIB so I injected a C++ alternative with a 'visitor' passed to the (allowed, added in R 4.6.0 aka R-devel) R_mapAttrib. With both these changes, the packages passes all checks under R-devel.
There are two small things remaining. Kurt added more URL checks, so your manual pages complain:
That should be easy to fix. More annoyingly, Luke has one more for you on
There is an entire new section Resizing Vectors in WRE that I can point you too, but I didn't want to make invasive changes. It seems like if you declare a vector 'resizable' on allocation you are allowed to shrink it.
Hope this helps, and once again thanks for considering these changes. Happy Holidays, and a Happy 2026!