Blogdown and bookdown examples need contents write permission#874
Merged
gaborcsardi merged 9 commits intor-lib:v2-branchfrom Aug 2, 2024
Merged
Blogdown and bookdown examples need contents write permission#874gaborcsardi merged 9 commits intor-lib:v2-branchfrom
gaborcsardi merged 9 commits intor-lib:v2-branchfrom
Conversation
Contributor
Author
|
I think the pr-commands.yaml, document.yaml, and render-rmarkdown.yaml were also missing contents write permissions. So I have added that to those and regenerated examples/README.md |
|
Can confirm this issue for the (canonical) blogdown workflow. Without the write permission, the final "Deploy to GitHub Pages" step will have trouble writing to the gh-pages branch with the following error: |
nr0cinu
added a commit
to jmf-vienna/jmf-r
that referenced
this pull request
Jul 28, 2024
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think that both the blogdown.yaml and bookdown.yaml examples require to write to contents because they are using the gh-pages branch.