Grid and Cutout Dropout implementation by RooseweltMcW · Pull Request #553 · r-abishek/rpp

RooseweltMcW · 2025-12-15T17:12:44Z

No description provided.

… HOST AVX, SSE

…ents

…all the bitdepths

…performance

…images in the docs

…opout

… i8 variant

indentation modified

…ied QA for logic to implement random seed for non QA

Srihari-mcw · 2025-12-18T02:44:17Z

src/modules/tensor/cpu/kernel/erase.cpp

                dstPtrRowG += dstDescPtr->strides.hStride;
                dstPtrRowB += dstDescPtr->strides.hStride;
            }
+            for(int count = 0; count < numBoxes; count++)


Did we check the impact on erase due to all these changes?

reverted back, Done

* Fix log1p test suite upgrades for HIP * Updates for HOST Test Fixes * Fixes for box filter * Remove hardcoding of channel details * Update utilities/test_suite/rpp_test_suite_misc.h Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HIP/Tensor_misc_hip.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>

…opout

HazarathKumarM · 2025-12-22T16:50:08Z

api/rppt_tensor_effects_augmentations.h

 #endif // GPU_SUPPORT

+/*! \brief Cutout dropout augmentation on HOST backend for a NCHW/NHWC layout tensor
+ * \details Cutout dropout function erases one random regions from an image, for a batch of RGB(3 channel) / greyscale(1 channel) images with an NHWC/NCHW tensor layout.<br>


change it like
Cutout dropout function erases random region from an image

HazarathKumarM · 2025-12-22T16:52:09Z

api/rppt_tensor_effects_augmentations.h

+ * \param [in] srcDescPtr source tensor descriptor (Restrictions - numDims = 4, offsetInBytes >= 0, dataType = U8/F16/F32/I8, layout = NCHW/NHWC, c = 1/3)
+ * \param [out] dstPtr destination tensor in HIP memory
+ * \param [in] dstDescPtr destination tensor descriptor (Restrictions - numDims = 4, offsetInBytes >= 0, dataType = U8/F16/F32/I8, layout = NCHW/NHWC, c = same as that of srcDescPtr)
+ * \param [in] anchorBoxInfoTensor Precomputed cutout erase regions for the batch, stored as an array of RpptRoiLtrb of size (batchSize * boxesInEachImage)


please add the memory types like pinned / HIP for all the params

HazarathKumarM · 2025-12-22T16:54:26Z

api/rppt_tensor_effects_augmentations.h

+ * \param [in] srcDescPtr source tensor descriptor (Restrictions - numDims = 4, offsetInBytes >= 0, dataType = U8/F16/F32/I8, layout = NCHW/NHWC, c = 1/3)
+ * \param [out] dstPtr destination tensor in HIP memory
+ * \param [in] dstDescPtr destination tensor descriptor (Restrictions - numDims = 4, offsetInBytes >= 0, dataType = U8/F16/F32/I8, layout = NCHW/NHWC, c = same as that of srcDescPtr)
+ * \param [in] anchorBoxInfoTensor Precomputed grid erase regions for the batch, stored as an array of RpptRoiLtrb of size (batchSize * boxesInEachImage)


specify the memory type

HazarathKumarM · 2025-12-22T16:55:26Z

src/include/tensor/api_helpers.hpp


 #include "rpp.h"
 #include "rppdefs.h"
+#include <random>


why this is included here, please check and remove if it's not needed

Removed, Done.

HazarathKumarM · 2025-12-22T16:59:05Z

src/modules/tensor/rppt_tensor_effects_augmentations.cpp

+                                   RppPtr_t dstPtr,
+                                   RpptDescPtr dstDescPtr,
+                                   RpptRoiLtrb *anchorBoxInfoTensor,
+                                   RppPtr_t colorsTensor,


why colors tensor is void *?

is it not black always?

Followed similar parameter used in erase kernel for color tensor

…opout

* Fix log1p test suite upgrades for HIP * Updates for HOST Test Fixes * Fixes for box filter * Remove hardcoding of channel details * Update utilities/test_suite/rpp_test_suite_misc.h Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HIP/Tensor_misc_hip.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>

r-abishek · 2026-02-18T00:50:07Z

@HazarathKumarM @RooseweltMcW ToT merge and Unified API changes to be reflected.

…ut and updated grid and cutout dropout with unified API changes

r-abishek

@HazarathKumarM @RooseweltMcW Pls take a look.

r-abishek · 2026-02-18T23:21:30Z

src/modules/tensor/hip/kernel/grid_dropout.cpp

+    Rpp32u totalBoxes = srcDescPtr->n * boxesInEachImage;
+
+    RpptRoiLtrb *d_anchorBoxInfoTensor;
+    hipMalloc(&d_anchorBoxInfoTensor, totalBoxes * sizeof(RpptRoiLtrb));


@HazarathKumarM Why do we have a hipMalloc here inside the kernel?
Can't use any of our pre-allocated hip buffer? Or the preallocated pinned memory?

Modified and updated, Done.

RooseweltMcW · 2026-02-20T05:24:53Z

@r-abishek Resolved review comments

snehaa8 and others added 30 commits August 22, 2025 07:39

Optimized version of channel dropout HIP backend and working code for…

e32bbdb

… HOST AVX, SSE

Modified name for dropout compute function

a1fdab1

Modified way of AVX and SSE version channel dropout to avoid if statm…

4c7e1a1

…ents

Modified Channel Dropout with generic compute code reused

5747ea0

Parameters and name change for channel dropout

133236a

Modified HIP for better performance

1fb450e

Modified the code and made the channel dropout templated version for …

63491ac

…all the bitdepths

Modified Erase kernel for grid and cutout dropout version for better …

836ff59

…performance

Modified the .h file to have the dropout to effects and added output …

c9babec

…images in the docs

Added output image and modified the .h file to effects for channel dr…

a374034

…opout

Removed space

f308bbe

added space

709809d

Moved grid dropout .h to effects

938d876

Modified channel dropout for I8 variant HOST side

0bd5686

Resolved all review comments and modified code to produce results for…

751cf48

… i8 variant

Removed empty line

d597022

merged the changes of channel dropout commit to grid, cutout dropout

a0d9ff0

Resolved review comments

4038129

Merge remote-tracking branch 'tot/develop' into apr/channel_dropout

24cada0

Modified HOST after merge

24968cf

Made changes after merging and QA passed for dropout

cbc74c8

Channel dropout make_float 4 macro changes

1baa41e

Updated QA with random generator and updated BIN files

ac97a1e

Modified QA name changes

cd5c576

Merge branch 'apr/channel_dropout' into apr/grid_cutout_dropout

bc62008

Modified RandomSeed value passed as parameter to the function call

09f993c

Update rppt_tensor_effects_augmentations.cpp

da78859

indentation modified

Merge branch 'apr/channel_dropout' into apr/grid_cutout_dropout modif…

ed13d97

…ied QA for logic to implement random seed for non QA

Initial modified HIP backend Grid dropout with better performance

3deb6bd

Removed space and review comments resolved

f0e2195

Srihari-mcw reviewed Dec 18, 2025

View reviewed changes

HazarathKumarM added 5 commits December 22, 2025 01:12

Updated grid dropout random logic to be done in test suite

567ca4f

Updated test suite

a441c9f

Merge remote-tracking branch 'origin/develop' into apr/grid_cutout_dr…

e03a5be

…opout

Modified test suite to do randomization in test suite level

6feafb3

Reverted erase kernel implementation

bf3c50d

HazarathKumarM reviewed Dec 22, 2025

View reviewed changes

HazarathKumarM added 5 commits December 23, 2025 06:36

uremoved unused include functions and modified the documentation

0c5bfe9

Review comments resolved

40b72c9

Removed unsued parameters

669d699

Clean ups and modifications in dropout erase function

3fbff03

Merge remote-tracking branch 'origin/develop' into apr/grid_cutout_dr…

e3fa4d1

…opout

HazarathKumarM changed the base branch from develop to master January 13, 2026 09:52

HazarathKumarM changed the base branch from master to develop January 13, 2026 09:52

HazarathKumarM added 3 commits January 19, 2026 04:20

Updated and tested QA after test suite modifications

62b8126

Updated and tested QA after test suite modifications

556408a

Merge remote-tracking branch 'tot/develop' into apr/grid_cutout_dropout

6792868

Merge remote-tracking branch 'tot/develop' into apr/grid_cutout_dropo…

3c2ce58

…ut and updated grid and cutout dropout with unified API changes

r-abishek requested changes Feb 18, 2026

View reviewed changes

r-abishek assigned HazarathKumarM and RooseweltMcW Feb 18, 2026

r-abishek added the enhancement New feature or request label Feb 18, 2026

r-abishek changed the base branch from develop to ar/dropout_grid_cutout February 18, 2026 23:25

Resolved review comments

1ad400d

r-abishek approved these changes Feb 21, 2026

View reviewed changes

r-abishek merged commit 3f1c095 into r-abishek:ar/dropout_grid_cutout Feb 21, 2026

Conversation

RooseweltMcW commented Dec 15, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

r-abishek commented Feb 18, 2026

Uh oh!

r-abishek left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RooseweltMcW commented Feb 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants